Karma -- is too greedy about nerdbot HOT 16 CLOSED

+1, I do this all the time.

from nerdbot.

Someone will probably need to fork the karma script like we did for applause. We could also turn it off, but one could argue it's become part of the chat culture.

from nerdbot.

Maybe I just haven't seen it but I'd say making fun of nerdbot for getting -- wrong is more a part of the culture than the actual usage of that feature :)

from nerdbot.

That's certainly true, now it's taken on a life of it's own. Time to print up tshirts.

from nerdbot.

On our team we use ++ as "thank you" - I'd hate to see it go away. Probably should only apply after an "@" reference.

from nerdbot.

Just about ready to submit a pull request:

• Requires an @ character at the beginning of the string
• No longer allows a space in between the string and the ++ or --

One potential impact though is currently (cooltom) is No. 1 on the karma list:

Thoughts on how we should handle this? maybe allow paren strings as things that can get karma?

from nerdbot.

I would allow a space after the @ string since autocomplete adds one by default. I would be ok with a paren as well, but I don't think it's critical. Something like /(@[a-zA-Z0-9]+\s*)|(([a-zA-Z0-9]+))(++|--)/ would match (he says without actually trying it).

What would you think of restricting it to the start of the line?

from nerdbot.

start of line would make the most sense -- if it wasn't start of line and you allowed spaces between the name and ++/-- then you'd have cases where you have a string like:

hey @tvanfosson -- check this thing out

and it'd still trigger.

from nerdbot.

Or you could constrain the ++/-- to be the last thing on the line. That would be super simple and it's unlikely that we'd have any false positives. /(++|--)\s*$/

from nerdbot.

Interesting:

   robot.logger.warning "karma.coffee has merged with plusplus.coffee and moved from hubot-scripts to its own package. Remove it from your hubot-scripts.json and see https://github.com/ajacksified/hubot-plusplus for upgrade instructions"

Going to try and see if this one works better.

from nerdbot.

Related #7

from nerdbot.

Opinions on the merged plusplus script &/or Aaron's PR?

from nerdbot.

I honestly don't care that much, whatever is easiest and prevents it from picking up in normal chat when it's clearly not intended. I think PR #7 is a fine solution (only allow at beginning)

from nerdbot.

My bad, I didn't realize there was already discussion on this. I don't really care what the solution is, I just find the '--' thing really annoying.

from nerdbot.

np @amarasco -- I actually started working on a solution before I started diving down the node / hipchat rabbit hole for trying to test out the changes and got lost.

My vote is to accept PR

from nerdbot.

Merged PR #7.

from nerdbot.