theoneric / cr-fixes Goto Github PK

Since Ellation/Crunchyroll transitioned to the new new HTML-Player (early 2020) the language and quality auto selection does no longer work. So far so unsurprising. The catch is that the HTML-Elements did not just get moved/renamed but rather the player now removes and adds HTML-elements every time they want to show some player UI.
Not only is this very inefficient, it also means that we can no longer easily trigger the button events to set quality and language – there are no buttons.
Simulating mouse movements seems difficult or impossible as Firefox places restrictions on those for security reasons, so getting the buttons to show up is also difficult.

Frankly, I don't see a way to get this to work without ridiculous effort like locating the right calls in the minified JS code, which frequently changes.
If anybody feels like figuring out a solution, that doesn't break with every minor update of CR's js code, I'll accept GitHub-pullrequests or git format-patch per email.

In the meantime I'll disable those options in settings.

---

Footnote:
Apparently they are using React[1] which seems to have a more convenient way for devs to add and and delete HTML-Nodes, which might explain why this is done so needlessly inefficient (disabling and enabling is not only faster, but also still easier than Reacts adding/deleting btw).

[1]: https://web.archive.org/web/20200203224503/https://blog.ellation.com/velocity-crunchyrolls-universal-react-player-e70a61b6dfa7?gi=1aaf43b55389