theopn / theovim Goto Github PK

Expected Behavior

When the floating help window is closed, it should leave no residues behind.

Actual Behavior

The buffer is simply unloaded from the buffer list, as shown in the ls! command result.

Steps to Reproduce the Problem

0. Open help window
1. Close help window
2. Use :ls!

Specifications

• Neovim Version: 0.9.1
• Theovim Commit Version: main a8e4dda
• Platform: MacOS 13.4.1 (c)
• Terminal Emulator: Wezterm

Expected Behavior

:TheovimUpdate command should open a mini terminal, git pull the new update, and let user know that it was successful/unsuccessful doing so.

Actual Behavior

If the exit code is 0 (i.e. it was able to update Theovim or there was no change after git pull), the term window closes itself.

It's probably due to the new TermClose autocmd (https://github.com/theopn/theovim/blob/main/lua/core.lua#L153) introduced in v.2023.07.29.

Steps to Reproduce the Problem

0. Open Theovim in an environment where update would succeed (git installed, stable internet connection, no git conflict, etc.)
1. Use :TheovimUpdate command

Specifications

• Neovim Version: 0.9.1
• Theovim Commit Version: main a8e4dda
• Platform: MacOS 13.4.1 (c)
• Terminal Emulator: Wezterm

When creating a new split-screen with [Space] + z within Theovim, a new tab called zsh is automatically created.

Attempting to close this tab results in errors:

It is then impossible to close the automatically created zsh tab without closing the split-screen view. This occurs every single time the split-screen is started.

Expected Behavior

Dashboard is supposed to open.

Actual Behavior

Neovim crashes and leaves un-highlighted Dashboard contents, and the buffer is modifiable with number and other settings that are supposed to be off in Dashboard turned off.

The error message is:

Error executing vim.schedule lua callback: /Users/username/.config/nvim/lua/ui/dashboard.lua:178: Column value outside range
stack traceback:
        [C]: in function 'nvim_win_set_cursor'
        /Users/username/.config/nvim/lua/ui/dashboard.lua:178: in function </Users/parktheo0/.config/nvim/lua/ui/dashboard.lua:103>

Screenshots:

Steps to Reproduce the Problem

1. Either launch the Neovim with terminal window narrow enough that the dashboard contents wouldn't fit
2. Or launch Neovim normally and adjust the terminal window

Specifications

• Neovim Version: 0.9.1
• Theovim Commit Version: dev 9ea8b5b
• Platform: MacOS 13.4.1
• Terminal Emulator: Kitty with Tmux

Expected Behavior

The floating window that houses shell or termopen should be gone when it's closed, which it does in regular buffers.

Actual Behavior

When the floating shell/terminal is open in dashboard, it leaves the frame of the floating window even after it's closed.

Following image was the demonstration of the bug with floating shell:

Following image was the demonstration of the bug with :TheovimUpdate:

Note that this is one-time thing. For instance, if you open the floating terminal, close the residue window using :q, and open the floating window and close again, the window disappears as expected.

Steps to Reproduce the Problem

0. Open Dashboard
1. Use :TheovimUpdate or floating terminal feature
2. Close them by completing the update or exiting the terminal

Specifications

• Neovim Version: 0.9.1
• Theovim Commit Version: dev branch 6f43a4b
• Platform: MacOS 13.4.1 (c)
• Terminal Emulator: Wezterm