thesunsavior / console_client_server_application Goto Github PK

As I said before

• We are targeting C++17, not C++14, please change it in your CMakeLists.txt
• Follow Google C++ style guide, for example, change the file name to lower_case
• Format with clang-format, I don't see you using it in your project
• The folder structure should follow Pitchfork Layout. Please take a look at my repos as an example. You are separating your repo into 2 projects, corresponding to 2 folders, which is not necessary. Your repo should look like this:

src/
| - admin/
|    | - sources.cc
|    | - sources.h
|    | - CMakeLists.txt
| - node/
|    | - sources.cc
|    | - sources.h
|    | - CMakeLists.txt
CMakeLists.txt    # this one should be the root CMake files
.clang-format   # format configuration

• Also, do not push build files to the repo (cmake-debug folder), use .gitignore to remove them.
• Follow Modern CMake for C++, write your codes as target-driven. For example:
  • you can create 2 executable targets for Admin and Server/Client.
  • stop using include_directories without the knowledge of what it is, use target_include_directores, target_sources, target_link_library, etc. Take a look at my repo as a reference.