thewizrd / itunes-smtc Goto Github PK

I recently tried using your App and it works great so thank you. However, I noticed a bug where the
_iTunesApp object wasn’t correctly destroyed when closing iTunes. This causes iTunes to display a
Popup that an App is still using the iTunes interface and waits 20 before closing automatically.

Steps to reproduce:

1. Start the iTunes-SMTC App
2. Start iTunes
3. Press Play to start a song
4. Close iTunes
5. The above-mentioned message appears

I had a look at the code myself and found this Code in the DisconnectiTunes() method:

if (_iTunesApp != null)
{
    Debug.WriteLine("Releasing iTunes COM object...");
    wasAlive = true;
    RemoveEvents();
    Marshal.FinalReleaseComObject(_iTunesApp);
    GC.Collect();
}
_iTunesApp = null;
if (_currentTrack != null)
{
    Marshal.FinalReleaseComObject(_currentTrack);
    GC.Collect();
}
_currentTrack = null;

You can try the the Fix in my fork here: https://github.com/AD4MANTIS/iTunes-SMTC
The relevant comit is here: AD4MANTIS@a4db419

For me this fix works when I open the settings UI once before playing the first song with iTunes. The UI
doesn’t need to be open when pressing play to work. It’s the same thing when opening iTunes again
after closing it. If I don’t open the settings UI before playing the first song it gives me the message,
otherwise it closes normally.

I'm not sure what causes this, so maybe do you have an idea?

If song switches to one without a media thumbnail (image), the previous songs one is used. In this case it should be blank

Hi @thewizrd, im one of the developers of ModernFlyouts, i came across this project after one of our contributors added it to the list of extensions to get around problems with apps not supporting STMC. Nice project by the way, very useful.

I just thought I would enquire whether you would be interested in a collaboration of some sort to add this functionality to ModernFlyouts, possibly thought adapting this into an extension?