thibaultjanbeyer / joplin-sheets Goto Github PK

greetings,
How do I reopen a sheet?

Please make sure that the version numbers in package.json and manifest.json match.

Right now the plugin version number is 1.0.0, but it is published to npm as 0.1.1

On another note, does this plugin use a 3rd party server or do you bundle luckysheet with the plugin? In either case this should be mentioned in the README. You can also create a topic in https://discourse.joplinapp.org/c/plugins/18 to promote your plugin. (Your choice of course.)

Could the edited cells be rendered as a table in "view"?

Currently the split position is not saved per note, so one needs to resize every time when opening. There is no need for the code view with this plugin, so I suggest hiding it on plugin load.

Currently, JSheets creates a new panel whenever it is opened. This is pretty annoying since it always opens on the right which might not be the most useful place to have it, this means frequently having to rearrange panels in most cases. Those panels are also not destroyed after use so they can massively pile up...

It looks like in the code you say this is due to reliability reasons link, just wondering if there's a workaround for this? Maybe destroying the contents of the panel but not the panel itself?

as luckysheets isn't being maintained, can we update to use univer instead?

Currently JSheets uses a built-in theme which looks good but doesn't update depending on the theme set in Joplin which can be pretty jarring especially is Joplin is in a dark mode theme and JSheets is in light mode

Is it possible to update the css to more closely represent base Joplin?

I'm using Joplin 2.10.4 beta on Windows 11. If I exit (<) the Luckysheet spreadsheet in one note, then switch to another note, Joplin crashes. Following is the crash page info:

Error
Joplin encountered a fatal error and could not continue.

To report the error, please copy the entire content of this page and post it on Joplin forum or GitHub.

If the error persists you may try to restart in safe mode, which will temporarily disable all plugins.

Message
frameWindow.removeEventListener is not a function

Version info
Joplin for Desktop

Copyright © 2016-2023 Laurent Cozic
Joplin 2.10.4 (prod, win32)

Client ID: 60f49bd2f7c540e88c13d1caf6ae8a8b
Sync Version: 3
Profile Version: 41
Keychain Supported: Yes

Revision: 9866e59
Plugins
[
{
"id": "joplin.plugin.note.tabs",
"name": "Note Tabs",
"enabled": true,
"version": "1.4.0"
},
{
"id": "com.whatever.quick-links",
"name": "Quick Links",
"enabled": true,
"version": "1.2.3"
},
{
"id": "io.github.jackgruber.copytags",
"name": "Tagging",
"enabled": true,
"version": "1.0.1"
},
{
"id": "joplin-plugin-search-and-replace",
"name": "Search & Replace",
"enabled": true,
"version": "1.0.1"
},
{
"id": "joplin.plugin.ambrt.convertToNewNote",
"name": "Convert Text To New Note",
"enabled": true,
"version": "1.5.1"
},
{
"id": "joplin.plugin.ambrt.copyNoteLink",
"name": "Copy link to active note",
"enabled": true,
"version": "1.0.1"
},
{
"id": "de.habelt.CsvImport",
"name": "Csv Import",
"enabled": true,
"version": "1.0.1"
},
{
"id": "joplin.plugin.ambrt.embedSearch",
"name": "Embed Search",
"enabled": true,
"version": "2.0.0"
},
{
"id": "joplin.plugin.benji.favorites",
"name": "Favorites",
"enabled": true,
"version": "1.3.0"
},
{
"id": "io.github.personalizedrefrigerator.js-draw",
"name": "Freehand Drawing",
"enabled": true,
"version": "1.4.1"
},
{
"id": "joplin.plugin.alondmnt.suitcase",
"name": "Suitcase",
"enabled": true,
"version": "0.2.1"
},
{
"id": "sadmice.TextColorize",
"name": "Text Colorize",
"enabled": true,
"version": "1.2.3"
},
{
"id": "joplin.plugin.templates",
"name": "Templates",
"enabled": true,
"version": "2.3.0"
},
{
"id": "joplin-plugin-dddot",
"name": "Joplin DDDot",
"enabled": true,
"version": "0.2.0"
},
{
"id": "outline",
"name": "Outline",
"enabled": false,
"version": "1.5.6"
},
{
"id": "com.joplin.excalidraw",
"name": "joplin-excalidraw",
"enabled": true,
"version": "1.3.0"
},
{
"id": "com.github.marc0l92.joplin-plugin-drawio",
"name": "Draw.io",
"enabled": true,
"version": "2.1.0"
},
{
"id": "com.joplin.JSheets",
"name": "JSheets",
"enabled": true,
"version": "1.1.3"
}
]
Stack trace
TypeError: frameWindow.removeEventListener is not a function
at C:\Users\steve\AppData\Local\Programs\Joplin\resources\app.asar\services\plugins\hooks\useWebviewToPluginMessages.js:34:25
at safelyCallDestroy (C:\Users\steve\AppData\Local\Programs\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:22932:5)
at commitHookEffectListUnmount (C:\Users\steve\AppData\Local\Programs\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:23100:11)
at commitPassiveUnmountInsideDeletedTreeOnFiber (C:\Users\steve\AppData\Local\Programs\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:25098:11)
at commitPassiveUnmountEffectsInsideOfDeletedTree_begin (C:\Users\steve\AppData\Local\Programs\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:25048:5)
at commitPassiveUnmountEffects_begin (C:\Users\steve\AppData\Local\Programs\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:24956:11)
at commitPassiveUnmountEffects (C:\Users\steve\AppData\Local\Programs\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:24941:3)
at flushPassiveEffectsImpl (C:\Users\steve\AppData\Local\Programs\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:27038:3)
at flushPassiveEffects (C:\Users\steve\AppData\Local\Programs\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:26984:14)
at commitRootImpl (C:\Users\steve\AppData\Local\Programs\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:26935:5)
Component stack

at UserWebview (C:\Users\steve\AppData\Local\Programs\Joplin\resources\app.asar\services\plugins\UserWebview.js:42:28)
at div
at I (C:\Users\steve\AppData\Local\Programs\Joplin\resources\app.asar\node_modules\styled-components\dist\styled-components.cjs.js:1:19344)
at div