thisisnttheway / rack_nixie_display Goto Github PK

If the request body sets pwm to 0, it is not actually updated in the displayController.tubes array.

Suspected code in websrv.cpp:

if (tube.value()["pwm"]) {
    // ...
}

0 at this point also represents a logical false, thus not satisfying this condition.
An alternate check if this property is present should be implemented.

Using an ADC reading of 758, the ESP calculates the temperature to be ~202 °C.

ntpSource is garbled text.
As such, the system cannot perform a valid NTP request.
Additionally, /api/system will also return garbled text.

In the request body, if the tubes array does not contain a PWM value for a corresponding tube, the PWM will be set to 0.

This is probably due to this code:

// websrv.cpp
int tubeIndex = atol(tube.key().c_str());
int tubePWM = tube.value()["pwm"].as<int>(); // <-- gets interpreted as 0 if missing/is NULL.

ToDo:
Check if argument PWM is present.

Error possibly in websrv.cpp.