Current Behaviour
Problems, Frustrations, General Description
For templates with reacts in the reacts
section that have the onHeadcount
parameter set to true
, these reacts will all appear before the default reacts that appear from the buttons
section. At times this can be intuitive as the most essential reacts to check is the number of raiders and the number of keys/other consumables available. While the number of raiders is a react in the reacts
section, there may be other less essential reacts that have onHeadcount
set to true, thus appearing before keys and other consumables.
How to Reproduce
While all templates do not display this issue, one such template that has this issue is the standard cult template. To see an instance of a react appearing prior to the essential key react, run ;headcount cult
.
Wanted/Expected Behaviour
Improvements, Additions, Changes
Fix the ordering of the reacts such that the essential ones defined appear before the non-essential normal reacts. The manner in which this is done must be flexible and must not be hard-coded to ensure this behaviour can be configured in the future if necessary.
Alternatives
One option is simply to remove non-essential reacts in the reacts
section of a template all-together, opting only to use the raider react to ensure ordering is maintained. Another option is to define ordering explicitly for each template. Another option is to have a parameter or mechanism for defining the essential reacts to ensure they always appear before normal reacts.
Reasoning
Regardless of whatever alternative is used, ideally it should be something that is easy to incorporate and has minimal effect on template definitions as this is a massive file that will require a lot of work to change. It should also be something that isn't hardcoded and flexible, keeping in mind the requirements of runs or the ordering of reacts may change in the future.
Tasks
Things to Do
Paths to Files
Examples/Screenshots
Screenshots of Bug, Examples for Features