thomasmcdonald / code-collaborator Goto Github PK

Stop document from saving when the cursor changes.

Proposed Fix:
Sneaky If statement in the below function to check type isnt cursor before sending content to save.

sendData(type,message){
      if(this.silent || this.isDocLoad) return;
      this.socketService.sendData(type,this.document._roomID,message);
      this.document._content = this.editor.getEditor().session.getDocument().$lines;
      this.socketService.saveData(this.document);
    }

Change room generator to server side so it can check if the room exists.
If the room exists it should then generate a different room that is available.

Routing directly to a document will crash the server if the particular document doesn't exist.

Steps to reproduce

• Run server
• Attempt to join a random room that hasn't been generated. i.e http://localhost:8080/tZiTSRyF1c

Possible Fix
When joining document an attempting to retrieve data, first check if room exists if not then add a room for that particular route and send empty document. This should work out fine.

Add a panel to the page that allows the user to edit:

• Title
• Syntax
• Tab size
• Theme
• Keymap

Give each connected user a cursor to indicate to other users of typing.

Add generic placeholder text that is visible before the user edits the document for the first time, basically show the below text when the document is empty.

"Write or paste code here then share. Collaboration is Live!"

Provide CRUD functionality for the documents.
Possible solutions with DB:

• Save the entire document object from the user each time its been edited.
• Cache edits to be saved later in a batch
• Save document to a txt file and save txt location in the DB.

Obviously these will be tested to find out the best solution.