thorswap / swapkit Goto Github PK

View Code? Open in Web Editor NEW

40.0 4.0 15.0 16.11 MB

SwapKit SDK - Integrate blockchains easily. Docs - https://docs.thorswap.finance/swapkit-docs

Home Page: https://swapkit.dev

License: Apache License 2.0

JavaScript 4.13% TypeScript 95.75% HTML 0.03% CSS 0.04% Handlebars 0.05%

blockchain web3 avalanche-c-chain bitcoin dogecoin ethereum thorchain bitcoin-cash hdwallet ledger

swapkit's Issues

Refactor input parameters to be primitives or non complex objects

wallet(new): Leap Wallet & Cosmostation

Leap wallet is supporting all Cosmos chains (In SwapKit's case Gaia and Kujira), and will have support for MAYAChain in the next few weeks.

Relevant docs
https://docs.leapwallet.io/cosmos/for-dapps-connect-to-leap/add-leap-to-existing-keplr-integration
https://docs.leapwallet.io/cosmos/for-dapps-connect-to-leap/add-leap-to-a-new-dapp

Error submitting deposits on Maya

Current behavior

All deposit transactions on the Maya chain are currently failing with the error below:

Error: Broadcasting transaction failed with code 6 (codespace: sdk). Log: all coins must be native to BASEChain: unknown request
at GA.broadcastTxSync
at async GA.broadcastTx
at async BA
at async Je$1.eval [as deposit]

How to reproduce:

const client = createSwapKit();
await client.connectKeystore(Chain.Maya, phrase);
const hash = await client.deposit({
    assetValue: new AssetValue({
      value: 1,
      decimal: 10,
      chain: Chain.Maya,
      symbol: 'CACAO',
    }),
    memo: test,
    recipient: '',
});

Also fails when registering a MayaName since it also a deposit:

const hash = await client.registerMayaname({
  name: 'test1',
  chain: Chain.Maya,
  assetValue: new AssetValue({
    value: getMAYANameCost(1),
    decimal: 10,
    chain: Chain.Maya,
    symbol: 'CACAO',
  }),
  address: 'maya1.....',
});

Expected behavior

It should work like it does for THORChain.

Functionality

Packages

Details

Package versions:

# Paste the output of `<npm|yarn|pnpm|bun pm> ls --depth=0 | grep @swapkit` here

[Docs]: Modular examples for wallet integrations & full featured example

swapkit(sdk): `dist` folder is not in the released

Current behavior

"@swapkit/sdk": "1.0.0-rc.129"

dist folder is not in the sdk

and therefore the import fails:

Expected behavior

dist folder exists

Functionality

Packages

Details

"@swapkit/sdk": "1.0.0-rc.129"

Missing Chains for currently implemented Wallets

Wallet Connect:

Keplr:

Kujira

Keystore:

Ledger:

OKX:

Kujira
Doge
LTC
Polkadot

Trezor:

Dash

Details

Not all wallets support all chains they can support. Chain support for the following wallets is missing:

[BUG] Playground mixed EVM network pairing

Describe the bug
ARB and BSC being intermingled on network selection via metamask. unable to test ARB

To Reproduce
Select ARB, select Metamask as wallet, see network switching to BSC then ARB, then see results show BSC

Expected behavior
Playground should pair arbitrium with a single network switch and show ARB assets

Screenshots

Info

*Chain: ARB
*Versions: Playground dev branch
Wallet (if applicable): Metamask
Browser (if applicable): Chrome

Additional context
Im running into this same network select issue when debugging KeepKey

[BUG] playground, unable to pair multiple network

Describe the bug
Unable to pair multiple networks. aka BSC + BTC via vite playground and trezor

To Reproduce
connect trezor, select BSC and BTC, select connect. see only 1 network pair

Expected behavior
both networks should pair and show balances

Screenshots

Info

*Chain: BSC BTC
*Versions: Develop
Wallet (if applicable): Trezor
Browser (if applicable): Chrome

Additional context
I am running into this same error debugging KeepKey

[R&D]: bip32 & bip39 alternatives

https://github.com/paulmillr/scure-bip32
https://github.com/paulmillr/scure-bip39

wallet(new): Add Sonar to connect to Kujira Network

Sonar is Kujiras Mobile Wallet, which also supports Desktops (throught scanning a QR Code)
example at e.g. https://blue.kujira.network

https://docs.kujira.app/dapps-and-infrastructure/kujira-wallet/using-sonar

Here is a sample implementation in the kujira.ui library, seems based on walletconnect
https://github.com/Team-Kujira/kujira.ui/blob/main/src/wallets/sonar.ts

docs(toolbox): Add KujiraToolbox and MayaToolbox to Documentation

Not sure were to add, do you have a public doc repo?

Can't find any references of KujiraToolbox or MayaToolboy in the Docs but it's already implemented in the Code.

https://docs.thorswap.finance/swapkit-docs/swapkit-sdk/toolboxes/cosmos#available-instances

I am trying to Integrate the SwapKit in Our App

I'm currently working on integrating SwapKit into my project, and I've come across a few challenges that I could use some guidance on. I've thoroughly reviewed the SDK code and explored the available APIs, but a couple of points are still unclear to me.
ThorName Integration:
I'm trying to understand how to add our ThorName in the SDK. The provided example lacks integration for this feature, and I'm unsure about the correct approach.
-where to get thorName (the mentioned website in the doc is not working )
Functionality Testing:
How can we effectively test the functionalities of SwapKit? Is any testnet available for testing, I'm looking for insights into a suitable testing strategy.
Service Fees :
I'm also seeking clarity on the fees associated with using SwapKit. Specifically, I'd like to know about our affiliate fee and whether there's a 30% fee mentioned in the documentation (uncertain if this is included or not)
If anyone has experience with these aspects of SwapKit or can provide guidance, I would greatly appreciate your insights. Additionally, i
Thank you in advance for your help!

thorswap / swapkit Goto Github PK

swapkit's People

Contributors

Stargazers

Watchers

Forkers

swapkit's Issues

Current behavior

How to reproduce:

Expected behavior

Functionality

Packages

Details

Current behavior

Expected behavior

Functionality

Packages

Details

Missing Chains for currently implemented Wallets

Details

Recommend Projects

Recommend Topics

Recommend Org