thriveweb / photoswipe-masonry-v2 Goto Github PK

"Don't use Masonry?" should be a gallery-level option rather than a plug-in level option

eg a site may have some galleries of "before and after" style sets of images, which make no sense if they are reordered by masonry.

Or in this case paintings and sketches: https://www.inkston.com/stories/produce/song-dynasty-gong-bi-hua-sketches/
I would put these into a gallery but I can't without turning masonry off for all galleries.

Similar to what they do here:
https://connekthq.com/plugins/ajax-load-more/examples/masonry/

since there is a workaround submitted for Facebook to close #18 let's split out the Twitter sharing.

The Photoswipe sharing to Twitter will result in either:

• an image share showing the post featured image (not the shared image), if the site uses Yoast or other SSO tool or has a theme that implements twitter cards
• Or a text share only, if the site has no SSO implementation.

The solution would be for the sharing links to include an additional featured image parameter on the shared Wordpress page link, and a php implementation to detect this parameter and override the featured image and ideally description, resulting in details for the current image appearing in:
<meta name="twitter:image"
<meta name="twitter:description"
so sharing sites that read this information can detect the image that was actually shared.

This is tracked here as is a wordpress specific solution and cannot be fixed by the generic Photoswipe.
For the moment it is proposed on #18 to hide the twitter sharing link as a temporary workaround.

https://wordpress.org/support/topic/compatibility-with-enhanced-media-library-2/

Sharing to Facebook etc doesn't share correct image.
When paging through a picture gallery, the code does not change the page level meta attributes.
This means that facebook gets the original page image (eg the WordPress Featured image) from the meta and not the image the user is trying to share.

To fix this, these types of properties need to be reset:

<meta property="og:image" content="">
<meta property="og:image:width" content="">
<meta property="og:image:height" content="">
<meta name="twitter:image" content="">

This might need to be done on the server, the add-in would need to set the featured image based on the &gid=psgal_280_2&pid=1 query string, since when facebook etc calls the site looking for the image for the post it's probably going for the meta directly without triggering the javascript.

thoughts?

While this doesn't work, the sharing should perhaps be disabled...

Hello Dev,
when I click on the thumbnail, first open the lightbox and then it open full url image.

I've set up the gallery with no url image but it seems not affect the gallery.

In console, there aren't js errors.

Can you help to figure out?

Thanks

Masonry option is relatively slow for large image galleries when compared to eg Robogallery which implements a lazy load masonry style gallery: an initial set of images are loaded into a masonry layout and more are added on scroll so initial load is fully minimized.

It would be good to have an option allow the gallery to be shown as a an embedded slider/slideshow as alternative to the masonry thumbnails. This should be a gallery option, or else a default option for large size gallery.
Combining in one plug-in would reduce the number of scripts/plugins needed, whereas at the moment it might be necessary to deactivate the plugin altogether to allow alternative options.

I'll recheck after wooCommerce 2.7 makes beta release label, since they are supposed to be buliding in FlexSlider.

Hi,
on the new settings page:

1. First install gives:
   " Notice: Undefined index: crop_thumbnails in ..wp-content/plugins/photoswipe-masonry/backend/settings-view.php on line 74
   />
   Crop thumbnails"

2. wording/phrasing around Thumbnail width is unclear:
   Thumbnail Width
   Set the width of the grid thumbnails
   Thumbnail Height
   Set the height of the grid thumbnails
   Is that setting max width and max height or min width and height, or absolute values? or is it absolute values if "Crop thumbnails" is also set.

3. if there is further work going into the plugin it may be preferable to remove ALL of the settings on this page and instead allow attributes on the gallery shortcode. Or as a secondary choice, keep the attributes but allow them to be overridden in the gallery shortcode.

4. 3 spelling errors in the sentence:

We reccomand you to regenerate your thumbnails te get te best result.

1. it's best to add a Settings link from the plugins.php listing to the settings page

On current master branch there is an extra gallery copy appearing at the top of the screen (output directly after body).
(tested eg with vanilla twenty-sixteen theme)

See https://wordpress.org/support/topic/serious-performance-issue-3/

on mouseover of any of the buttons at the top right, they all change to the show the zoom icon, they should just show change background colour without losing the action icon.

@deanoakley thanks for pointing me here. some of the wordpress forum moderators have been making it difficult for me to communicate there.

As mentioned on the WP support forums this plugin is working great under WP4.8. In fact, the idea that you leverage Galleries was such a great concept I can't believe how well the integration works. Kudos for picking up on that pattern. Until I saw it in your plugin instructions I didn't even know Galleries existed in WP.

Onto CI... Here's my plugin currently in development which I've used to built out an app to manage the plugin to prepare for automated deploys to SVN (because I only ever want to figure out how to do this once regardless of how many plugins I end up making):

https://github.com/comfusion/hyperdrive

Maybe it'll be useful as a reference.

The plugin started as a single functions PHP file written in a procedural style and has been expanded now to include conventionality standards taken from the sample plugin generated from the WP-CLI generator (which includes a Travis test rig for CI) as well as Patchwork and Kahlan for unit testing.

Just wanted to throw this out there and ask if you've found a good, repeatable method for deploying to SVN - that's something I still need in my plugin - which uses git tags and a conventional changelog. Thanks in advance for any feedback for insights you can provide. Cheers.

I'm not sure how tagging works for wordpress plugins, but something weird has happened. I'm pretty sure you meant to tag version 4.6.1 as 1.2.4?

I also would like to show TITLES in photoswipe. Additionally or instead of caption.

The photoswipe_thumbnails image size is unnecessary, since the native wordpress functionality allows the image size to be chosen when adding a wordpress gallery or image to a post. This is then used in the layout however the photoswipe attempts to use a different size thumbnail image than the one selected.

This line in photoswipe_masonry.php l468:
$thumb = wp_get_attachment_image_src( $aid , 'photoswipe_thumbnails');
can be changed to:
$thumb = wp_get_attachment_image_src( $aid , $size_class);

This means the right size images will be served up for the gallery thumbnails without any need to "rebuild thumbnails" to create the additional references.
As an additional alternative the images could be served one size larger than the selected size in order to support schemes which allow proportional image sizing and give smoother effect on initial zoom.

It's also unclear why the photoswipe_full image size in the following line would be necessary.

I want to have both video and photo so I've built my own masonry gallery using ACF and Macy.js

I just need to add lazy loading and a lightbox and photoswipe seems like a good solution. I've tried getting the normal photoswipe JS stuff to work on my website but I can't exactly make heads or tails of some of the documentation, so I thought about using this.

This works for galleries but can I get it to work for something else that's spit out by my wp-query custom fields loop?

Hi,

After the upgrade to version 1.2.1, linking directly to an image with ex. #&gid=1&pid=13 no longer works. It did work earlier (version 1.1.2 I think).

As a consequence, sharing from the lightbox (e.g. via Facebook) is also broken, since the link generated (with gid and pid) doesn’t point towards the image being shared.

It is also broken on the plugin homepage, for example:
http://thriveweb.com.au/the-lab/photoswipe/#&gid=1&pid=13

I wanted to downgrade to plugin version 1.1.2, but everything before version 1.2.0 seems to have been removed from SVN and Git, so now I’m stuck with a non-working version :-(

Please help, either by fixing the latest version, or by making version 1.1.2 available for downgrading.

Hi there,

I was just wondering if you guys are still working on this, as I've not seen updates in a long time.

Cheers,
Luca

https://wordpress.org/support/topic/page-jump-when-closing-the-gallery?replies=1#post-8552075

Gallery doesn't respect Wordpress gallery 'large' option: when 'large' is selected, the larger image references are loaded, slowing down the page, but the gallery only shows them at medium size.