throneteki / throneteki-client Goto Github PK

View Code? Open in Web Editor NEW

7.0 5.0 18.0 11.99 MB

The client code for Throneteki, a browser based implementation of the A Game Of Thrones LCG

Home Page: https://theironthrone.net

License: MIT License

JavaScript 91.14% Gherkin 0.67% Dockerfile 0.04% Less 7.94% Pug 0.22%

throneteki-client's Introduction

This repository is now archived and the client code can be found here

throneteki-client

The client code for Throneteki, a Web based implementation of A Game of Thrones LCG 2nd Edition

About

This is the one of the respositories for the code internally known as throneteki which is running on theironthrone.net allowing people to play AGoT 2nd edition online using only their browser.

Throneteki is split into multiple repositories to make the code more managable. This repository is for the client code.

Contributing

The code is written in node.js(server) and react.js(client). Feel free to make suggestions, implement new cards, refactor bits of the code that are a bit clunky(there's a few of those atm), raise pull requests or submit bug reports

If you are going to contribute code, try and follow the style of the existing code as much as possible and talk to me before engaging in any big refactors. Also bear in mind there is an .eslintrc file in the project so try to follow those rules. This linting will be enforced in the build checks and pull requests will not be merged if they fail checks.

Documentation for implementing cards

Issues

If you encounter any issues on the site or while playing games, please raise an issue with as much detail as possible.

Development

These instructions are only needed if you are actively working on the client.

git clone https://github.com/throneteki/throneteki-client.git
cd throneteki-client
npm install
npm run start

Coding Guidelines

All JavaScript code included in Throneteki should pass (no errors, no warnings) linting by ESLint, according to the rules defined in .eslintrc at the root of this repo. To manually check that that is indeed the case install ESLint and run

npm run lint

from repository's root.

Build Status

throneteki-client's People

Contributors

Stargazers

Watchers

Forkers

ystros duketax sbarnabas zacchiro ringsteki crescens evadlhorg romanogit flo06800 stopfstedt masterair adkateki rajboxer patane97 mmeldo throneteki-playtesting kahaanshah

throneteki-client's Issues

Deckbuilder: Copy&Paste from thronesDB not working for specific cards

Cards like Eddard Stark (WotN) and Robert Baratheon (LMHR) are on the melee restricted list and show up as Eddard Stark (WotN) [M] and Robert Baratheon (LMHR) [M] on thronesDB. If i just copy&paste a deck with those cards to throneteki, they are not correctly imported even though #110 is done and deployed. Without digging further, i would say the combination of a card pack in () and a RL/BL marker in [] is the problem here.

[J] and [M] restricted card indicators block smooth deck import from thronesdb

As the title says, when you import a deck from thronesdb, the new [J] and [M] restricted card indicators after the cards name make the deck import via copy&paste not work as smooth as before. you have to remove the indicators manually before the deck is registered as valid

Hidden areas should be shown when dragging cards

Currently, the shadow and out-of-game piles only display if there is at least 1 card in those piles. This makes it impossible to manually drag a card into those areas and makes people rely on awkward chat commands if they need to correct a mistake.

Search / look at prompts with a lot of cards requires scrolling

A search or look at prompt require the user to scroll through the menu prompt buttons when there are many options. We should come up with a better UI for these prompts.

Redesigned Agendas not importing correctly.

neither the short-hand nor long-hand form of the card's pack in parenthesis seems to work

companion ticket to ThronesDB/thronesdb#604

Deck editor crashes when trying to identify (wrong/mispelled) banners

When trying to identify the banners associated to an Alliance deck, and one of the Banners is unknown or mispelled deck editor crashes.

This happen also sistematically when Copying and Pasting from thronesdb an Alliance deck cause before the line with Packs: there are other lines like that are not banners nor the Alliance agenda itself.
for example:
Draw deck: 75 cards
Plot deck: 7 cards
The procedure assumes they are banners and tries to code them (causing the crash I presume).

To reproduce the crash copy and paste this in the deck editor:

Deck Greyjoy
House Greyjoy
Alliance
Banner of the Sun
Banner of the Wolf
Draw deck: 75 cards
Plot deck: 7 cards
Packs:

To avoid the crash remove the Draw deck and Plot deck lines

Deck Greyjoy
House Greyjoy
Alliance
Banner of the Sun
Banner of the Wolf
Packs: