tibagni / logviewer Goto Github PK

Is your feature request related to a problem? Please describe.
A user setting to specify the default location for log files (Similar to the configuration for filter)

1. Update Kotlin plugin version

Use FlatLaf
https://www.formdev.com/flatlaf/
https://github.com/JFormDesigner/FlatLaf

And abandon JTatoo

Is your feature request related to a problem? Please describe.
When I load more than one log file like main, radio, system, etc, it's not possible to choose
which one will be filtered.

Describe the solution you'd like
When there's more than one log file loaded, I would like to choose which log file to filter (one or more).
For example, in a first analysis, I may want to search only main and events log, but after that I may want
to remove events log and add system log. I'd like to be able to do that on the fly, without needing to reload the files in LogViewer.

Describe alternatives you've considered
Consider adding some checkboxes that will allow the user to select which log files will be filtered.
The user will be able to select one or more.

Description
After deleting a filter group, the user still see filtered logs using the deleted filters

To Reproduce
Steps to reproduce the behavior:

1. Open LogViewer and add a log file
2. Add a new filter group and add relevant filters to it.
3. Check if "Filtered logs" section populated
4. Delete the filter group.
5. Check if "Filtered logs" section is still populated.

Expected behavior
UI should refresh when a filter group is deleted.

Hi

I am really impressed with your work, want to contribute to your project.

Are you open to contributions?

Hi I would like to have filter out feature. We can filter out certain keywords from the logs and ignore them from "All logs" window. Also save them so that we can restore the ignore logs. Thanks!

if we double click one line of the original content (at the right top window), if it is already filtered into the right bottom window, make the same line in the right bottom window highlighted (Similar to what happens when a line is clicked on the filtered view)

Description
When the user loads a filter group from a file, all groups previously added are removed without a warning.

To Reproduce
Steps to reproduce the behavior:

1. Make sure you have at least one saved filter group
2. Open LogViewer and add one or more filter groups.
3. Click on Filters -> Open Filter... and select your saved filter group file.
4. Check that all previous groups were deleted.

Expected behavior
The filter group you've just loaded is below the previous filter groups you added.

Add the possibility to open multiple filter files, or append filter files so you can work with multiple set of filters at once

Is your feature request related to a problem? Please describe.
Presenting LogViewer can be tough since its font is always the same, relying on system configuration to set its size. People with bad sight might prefer larger fonts.

Describe the solution you'd like
Change font size and thickness though Settings.

Font Sizes: Small, Medium, Large, Extra Large...
Font Thickness: Default, Bold

Additional context
Consider make this change persistent.
Check if LogViewer needs to be restarted after changing the font configuration.

If any line in a filter file ends with "\r" parsing will fail

Is your feature request related to a problem? Please describe.
Currently the LogViewer only has a White background.
It would be nice if it provide a way to change the background color (for example, light gray)

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Select the text (Filter) when opening a filter for edit so it is easy to just change it quickly

When changing look and feel, main window is resized. Maybe it is better to only apply this setting after restart

Add a visual indication when there are changes to the filter file (New filters, removed or edited filters...)
And warn the user if he tries to close the window without saving the changes to the filters

It's a bit tricky to have to manually save filtered logs

To solve this I suggest adding a button in the main interface menu that allows you to save only the filtered logs that are in view

Describe the bug
Not possible to open logs that are not UTF-8 encoded

To Reproduce

1. Create a logfcat file
2. Change its encoding to anything that is not UTF-8
3. Try to open the logs with Log Viewer

Expected behavior
Logs can be opened with no problem (Or at least show a warning message saying the encoding is wrong)

Current behavior
"No Logs Found" message is shown

• CPU Usage can be read from
  ActivityManager: CPU usage from 30730ms to 222ms ago (2022-09-05 09:52:28.960 to 2022-09-05 09:52:59.467):
  ....

• Battery

• Memory

Whenever a filter is edited, it should take effect immediately on the filtered view, so we should just re-apply all the filters again (With the new modified filter)

Add a reload button to re-open the same log file(s) on one click.

Is your feature request related to a problem? Please describe.
Currently, when navigating through a filter, when the last log message is reached, navigation just stops instead of going back to the first one.

Describe the solution you'd like
When navigation reaches the last (or first) log message, go back to the first (or last) and show an indication on the screen (Like this toast implementation for swing: https://www.geeksforgeeks.org/java-swing-creating-toast-message/)

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe.
Many times during the debugging, I only have to look through DEBUG, WARN, or ERROR logs for a particular service/package. The current version doesn`t provide a direct way to filter out uninterested logs.

Describe the solution you'd like
There should be a way to check and uncheck each verbosity level in the filtered logs so that users can remove uninterested logs from the filtered logs easily.

Describe alternatives you've considered
Alternative can be reading through the uninterested logs or adding different regex patterns every time to filter out logs for particular verbosity levels and service/package.

Additional context
Use Android defined log levels: https://developer.android.com/reference/android/util/Log

Creat a settings option that will automatically load the last filter used on app startup

Describe the bug
When deleting a checked filter, the filters are not re-applied and the deleted filter continues to be applied

To Reproduce
Steps to reproduce the behavior:

1. Select 2 or more filters
2. Directly delete one selected filter
3. Filtered logs remain unchanged

Expected behavior
Deleted filter should be removed from filtered logs

As a LogViewer user I would like to know from which log file a specific log line is. A possible way to show that information is use a hint balloon when the mouse pointer stays for some seconds over a log line.

Describe the bug

The test method FiltersRepositoryTest.testPersistGroupMultipleFilters (line 409) fails when running on Windows 10:

]>
<Click to see difference>

]>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at com.tibagni.logviewer.FiltersRepositoryTests.testPersistGroupMultipleFilters(FiltersRepositoryTests.kt:409)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
[...]

To Reproduce

0. Make sure the OS is Windows;
1. Run the test FiltersRepositoryTest.testPersistGroupMultipleFilters (or run all tests);

Expected behavior

The test FiltersRepositoryTest.testPersistGroupMultipleFilters should pass.

Screenshots

Difference error:

Desktop:

• OS: Windows 10 (10.0.19043)
• JVM: 14.0.2
• Version of LogViewer: Git c44bb61