tibdex / autosquash Goto Github PK

It would be nice to wait for all pending reviews.

autosquash is really nice, coming from bors (and nothing before that). would it be possible to add an option to delete the squashed branch after merge ?

With the latest version, it seems that the code owner restriction is not considered when using autosquash.
We have the following restriction on our dev branch that uses autosquash:

Starting very recently (pretty confident that's when v 2.0.2 was rolled out), it seems that only having 2 reviewers was deemed enough even though no code owner singed off on the PRs.
And so the incoming PRs were let through, their branches merged to the dev branch and then deleted.
Pinning our usage to v 2.0.1 appears to get us rid of this unfortunate behavior.

We want people to approve a PR with small comments but not let the bot submit the PR until the author addresses the comments.

Hello!

First thanks got the nice project, very useful for simplifying the dev process!

One thing I could not debug successfully so far: we are seeing some "Error: Input required and not supplied: github_token" from time to time. It might be only on the "pull_request_review" events.

Would you have any idea on the root cause? Is there a way to get more debug info?
(run that failed, did not have autosquash label but another label, maybe related to label cloudera/hue#1881, note that we try to use github automerge too)

Run that failed:
https://github.com/cloudera/hue/runs/2122777923?check_suite_focus=true

All runs:
https://github.com/cloudera/hue/actions/workflows/autosquash.yml

Thanks!

See github/roadmap#107.

Hey, love this action - it's have been using it for a month and it's working great!

I was wondering if there's any specific reason for the fixed/hardcoded label?
If you're open to adding support for a custom label (declared in the workflow file) then I'd love to create a PR that does this.

I created a PR, added the expected label but the PR has not been updated despite been outdated.

I had similar issue with Autorebase App lately although previously it was perfectly working.

I don't think this is ideal given your comment: #24 (comment)

I would like my team to only focus on PR title and description - I am also enforcing semantic PR title for a clean commit history.

Hi,

Thank you for this amazing bot !

I would like to know if there is a way to avoid the merge commit when autosquash update the branch. Can i specify the update method (like merge/rebase) in the configuration ?

Example:

Thank you :)

I tried setting this up recently with a personal access token, ran into this error running the action. Pretty sure I set it up as per recommendations here. I did a search on github and looks like a few repositories there were succesfully using this at one point ran into the error and have removed the workflow as a result.

Is it possible to configure the action to only auto-update the branch but not auto-merge?
If it be controlled by different labels it'll be amazing (autosquash / automerge)

To avoid unnecessary merges and check runs, the search query for PR's could be updated to include review:approved. I'm not sure how this works in repositories that don't require approvals for merge, but perhaps the action could check requiresApprovingReviews and modify the query accordingly?

I have a personal repository where I mostly use PRs to run tests for me.
Therefore, every time I create a PR, I apply it the autosquash label, to have it merge as soon as tests pass.
Currently, I see that this workflow does not get the PR merged as expected [1]. At the end of all checks, I can remove and set again the label. This time, as previous validations were ok, the action is triggered and the merge occurs.

I know it is not the initial goal of this action, but I can't see why it is not triggered, as it seems to be the purpose of the type "check_run:completed_.

[1] (Kineolyan/snow-hall#7)
[2] (https://github.com/Kineolyan/snow-hall/pull/6/checks?check_run_id=370010823)

2020-03-02T21:45:04.4057734Z ##[section]Starting: Request a runner to run this job
2020-03-02T21:45:05.0278443Z Requesting a hosted runner in current repository's enterprise with labels: 'ubuntu-18.04', require runner match: True
2020-03-02T21:45:05.1196011Z Labels matched hosted runners has been found, waiting for one of them get assigned for this job.
2020-03-02T21:45:05.1811841Z ##[section]Finishing: Request a runner to run this job
2020-03-02T21:45:11.9129447Z Current runner version: '2.165.2'
2020-03-02T21:45:11.9130479Z Prepare workflow directory
2020-03-02T21:45:11.9305157Z Prepare all required actions
2020-03-02T21:45:11.9314318Z Download action repository 'tibdex/autosquash@v2'
2020-03-02T21:45:13.9503952Z ##[group]Run tibdex/autosquash@v2
2020-03-02T21:45:13.9504410Z with:
2020-03-02T21:45:13.9504792Z   github_token: ***
2020-03-02T21:45:13.9504965Z ##[endgroup]
2020-03-02T21:45:14.5134272Z Merge all pull requests on commit 723fb9d86a8a0daede1ddc73ad6a864ac9b51466
2020-03-02T21:45:14.5136268Z ##[error]Validation Failed
2020-03-02T21:45:14.5182792Z Cleaning up orphan processes

We're trying to set up autosquash in a repository and are getting the above error message. What steps can we take to troubleshoot this failure?

Do I have to name it like that when I create the token? Or should I paste the token plan in the yaml file?

Hi, I was wondering if the new workflow_run (https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_run) can be used to (reverse-)trigger one workflow from another, thus allowing the use of secrets.GITHUB_TOKEN.

Followed the instructions and setup a user with a a personal access token under AUTOSQUASH_TOKEN. It does not kick off the bot after all the github checks are done (saw that was reported already)

Also getting this cryptic error:

Deprecation: [@octokit/request-error] `error.code` is deprecated, use `error.status`.
    at RequestError.get (evalmachine.<anonymous>:1:84855)
    at isRetryError (evalmachine.<anonymous>:1:48989)
    at evalmachine.<anonymous>:1:49261
    at a.minTimeout (evalmachine.<anonymous>:1:39411)
    at processTicksAndRejections (internal/process/task_queues.js:93:5) {
  name: 'Deprecation'
}
Consider merging #2176
Fetching pull request details
Refetching details to know mergeable state
Refetching details to know mergeable state
Refetching details to know mergeable state
Refetching details to know mergeable state
Refetching details to know mergeable state
Refetching details to know mergeable state
Refetching details to know mergeable state
Refetching details to know mergeable state
Refetching details to know mergeable state
Refetching details to know mergeable state
Refetching details to know mergeable state
##[error]Not Found

Is this a setup issue?

I see it described in "The description of the pull request will become the message of the squashed commit."

Why is doing that? I don't see an option to disallow it.