Giter VIP home page Giter VIP logo

tiberiuzuld / angular-busy Goto Github PK

View Code? Open in Web Editor NEW

This project forked from cgross/angular-busy

23.0 23.0 4.0 10.96 MB

Show busy/loading indicators on any element during a promise/Observable.

Home Page: https://tiberiuzuld.github.io/angular-busy

License: MIT License

CSS 28.80% HTML 18.34% TypeScript 48.59% SCSS 4.27%
angular5 angularjs javascript loading loading-animations mask typescript

angular-busy's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

angular-busy's Issues

Update error message

Does the current 12.0.0 version still support boolean?

throw new Error('cgBusy expects a Promise ,an Observable or a Subscription');

If so, can this error include boolean so it is clear to other developers new to the component?

Multiple instances and AppModule

Hello,

I use the original cross/angular-busy in my AngularJS 1.6 app, so I was looking for something to work with Angular 5. This appears to be the perfect fit, but I'm having two issues:

  1. I can't seem to use multiple busy indicators on the same page. I get the following error when I do: "ERROR TypeError: Cannot read property 'style' of null". The cross version did support this. There is no issue if I only have one [cgBusy] on the page.

  2. I'd like to make this available via the AppModule instead of needing to add it to each {feature}Module. Is this possible?

I'm not doing any custom configuration. Just importing the module and using the [cgBusy] attribute. Any thoughts?

No Message Configuration

I would like to have just an icon spinner and no "Please Wait" message. Can these configurations be added to easily customize the spinner?

Angular 9 Support ?

I tried to update my project to Angular 9, but without having examined in too much depth, seemed to be having issues with angular-busy. For the time being canceled the update to Angular 9. Should anguler-busy work under Angular9 and/or are plans for a new version available?

Caching with ForkJoin Issue

Thanks for migrating this busy indicator to the latest angular version. I've been using cgBusy and its variants for a long time.

I've found an issue with it: when a forkJoin is used and all observables are returned immediately (client side caching in this case) and it errors out with the following.

ERROR TypeError: Unable to get property 'unsubscribe' of undefined or null reference

The error happens within cgBusy.service.ts. On line cgross#37 (inside the callThen function) is where the error actually happens. As you would expect subscription is undefined line cgross#37 is below:

subscription.unsubscribe();

The reason it is happening is because both of my services get cached and then they return immediately. When they return immediately, line# 37 executes before execution of line cgross#40 finishes. When I return the values immediately, I'm using the "of" RXjs operator.

If you need anything else let me know,

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.