tiffafoo / commoji Goto Github PK

Bug Description

An error message appears when trying to commit a message with emojis

Repro Steps

1. git commit -m "🐧Add a penguin"

Expected Behaviour

It should not do any prepending when there are emojis at the start of the commit message. Otherwise it should ignore the emojis and behave as normal.

Input1: 🐧Add a penguin
Output1: 🐧Add a penguin

Input2: Add a 🐧
Output2: ✨ Add a 🐧

Error logs

@matchai fill this

Describe the bug

Husky will overwrite or our hook and commoji will not work

Steps to reproduce

1. Go to a repo with husky configured on it
2. commoji --init
3. Error message appears

TODO: More clearer instructions are needed. Plox fill

Expected behavior

Screenshots

Environment (please complete the following information)

• OS: [e.g. iOS]:
• Terminal [e.g. iTerm]:
• Shell [e.g. fish]:
• commoji version [e.g. 1.0.0]:

Additional context

Feature Description

commoji should not prepend commit messages with emojis when it does not find a qualifying key in its json file.

Current Behaviour

Input: Hello I am a commit message
Output: _Hello I am a commit message (_ is there to represent a whitespace)

Desired Behaviour

Input: Hello I am a commit message
Output: Hello I am a commit message

Possible Implementation

We need to check what currently happens first.

Detailed Description

We want to uninstall in .git and such

Behaviour wanted

Possible Implementation

Detailed Description

Make the --global command, so commoji is automatically applied for all repos.

Behaviour wanted

commoji --global

Possible Implementation

1. Have global commit hook check for local commit hook.
2. When hook is running globally, check in commit folder's git hooks (PWD, $1, .git/hooks) and run theirs after ours
3. Send husky git arguments