tigoe / button Goto Github PK

I had to dig around in the .cpp file to figure out that a button is initialized via
"Button button = Button(3, BUTTON_PULLDOWN)"
rather than
"Button button = Button(3, PULLDOWN)"
as the documentation says.

I hate it when this happens, :( now I have to test every function in the library to make sure that it actually works as it should, due to not being able to trust the documentation.

A button click event should only be fired when the button was not held.

In Button.cpp

if (cb_onClick) {
  cb_onClick(*this);
} //fire the onClick event AFTER the onRelease

should be

if (!triggeredHoldEvent && cb_onClick) {
  cb_onClick(*this);
} //fire the onClick event AFTER the onRelease

In Button.h:

• unsigned int pressedStartTime;

should be

• unsigned long pressedStartTime;

as millis() returns unsigned long