tillbaks / node-itach Goto Github PK

Thanks for your library.

I have an IP2SL unit and have been experimenting with sending commands to a Meridian amplifier over RS232.

One issue I have discovered (and I am by no means an expert on serial comms) is that the response I get back is not captured cleanly by the data event. It comes in as packets, and the Meridian unit signifies that a packet has ended by adding a carriage return `\r'. I’m not sure if this is a standard or their own proprietary method.

I have been playing around with the itach.js file and have added a check for a carriage return and only resolve when this is present. However I imagine that this may break ir compatability?

I’m going to make a fork and will open a PR at some point to share what I come up with.