timgels / messenger-vision Goto Github PK

Some group members want spanish, however....

Sending large images can lock the connection for a single client for a long time, this is not desirable.

LoginName is misused for everything and whatnot. It's also copy-pasted multiple times just to change the text of a button... This should be done in the XAML directly.

Thrown when adding groups, see screenshot. Occurs since not awaiting adding groups to the UI.

Suggest reverting #b57d7e585e0a96b9a6ab19895b07054af21c84b4.

This method shall take a Type as parameter and use the coredispatcher to navigate to said argument. This way, no more viewmodels are cluttered with navigate methods.

Issue can be reproduced by hovering over the middle of the screen when there are no groups available.

Since commit #09a546d891f4baa410b3de81cbf2a219488bde23.

The JsonMessage properties can be used to create a message instead, and the class is no longer dependant on the server-only Client class. No abstraction layer between the Message and JsonMessage has to be maintained since the JsonMessage will then stand on it's own. This also makes it possible to share the data structure between the UWP client and the server using a .NET standard library.

cc @SietzeKoonstra @TimGels

It prevents the database to store images, since the database takes the payloaddata but the payloaddata return null if the imagestring is set. A TextMessage property should be created with such logic. Also the Message should have a constructor which takes the messagetype enum.

In Server.Helper.cs

Using ctrl+c to kill the server sends a FIN, so the client thinks there is nothing wrong (more specifically, CloseInternal gets called with error=false).

This logic needs to be reworked so that if the connection is lost in whatever way and client is still logged in, the ConnectionClosed event is invoked.

There are few issues:

• cannot navigate to mainpage once logged in (should be possible to view readonly settings)
• on AddGroupPage, an extra Group menu item is visible which shouldn't be