Giter VIP home page Giter VIP logo

Comments (6)

TimothyJones avatar TimothyJones commented on June 26, 2024

Apologies, somehow I missed this issue when you opened it.

I'm not certain whether Cognito uses refresh tokens with OpenID federation, so some investigation may be required. I don't believe it's mentioned in the documentation for the flow - Cognito generates its own refresh tokens (which are mentioned), but it's not clear whether refresh tokens are used with OIDC federation.

However, there are no technical challenges that I am currently aware of, and a PR to add this would be most welcome!

from github-cognito-openid-wrapper.

TimothyJones avatar TimothyJones commented on June 26, 2024

Now that I think about this, one issue may be that GitHub doesn't issue refresh tokens (as far as I remember).

If this is the case, the feature would still be useful if people are using this wrapper for other OAuth services - I've thought about making that part more general.

from github-cognito-openid-wrapper.

TimothyJones avatar TimothyJones commented on June 26, 2024

@ispyinternet Did you get anywhere with this?

from github-cognito-openid-wrapper.

ispyinternet avatar ispyinternet commented on June 26, 2024

Haven’t had a chance to look yet

from github-cognito-openid-wrapper.

TimothyJones avatar TimothyJones commented on June 26, 2024

Further to this, it looks like github now supports refresh tokens, but only through their beta program (at the moment). I'm not sure if you'd want to rely on this in production, since "features in the public beta are subject to change":

https://docs.github.com/en/free-pro-team@latest/developers/apps/refreshing-user-to-server-access-tokens

Anyway, it would be possible to extend the github connector to request and return refresh tokens, but I'm still unclear on whether Cognito would use them.

from github-cognito-openid-wrapper.

sambhavjain9138 avatar sambhavjain9138 commented on June 26, 2024

@TimothyJones The Link you last shared has provision to call for new access token using the refresh token. But, the link is for github apps and not Oauth app. Also I am not sure if i receive any refresh token from the github's side.
Access Tokens has some expiry period right?
Can you please help me with this?

from github-cognito-openid-wrapper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.