Giter VIP home page Giter VIP logo

Comments (8)

timstableford avatar timstableford commented on July 19, 2024

This works on Android 6.0 and 4.4. Does the first message on the training screen say your assistants name or does it say 'null'?

from p-brainandroid.

patrickjquinn avatar patrickjquinn commented on July 19, 2024

While holding the microphone say " so yep looks like its null!

from p-brainandroid.

timstableford avatar timstableford commented on July 19, 2024

This definitely isn't a null name issue. It seems to be that the name is a 0 length string. Is your server sending a name through the set_name socket command?

from p-brainandroid.

timstableford avatar timstableford commented on July 19, 2024

(or is the name right in config/name.json)

from p-brainandroid.

patrickjquinn avatar patrickjquinn commented on July 19, 2024

AH! Name is name:"" in the name.json file. My bad!

from p-brainandroid.

timstableford avatar timstableford commented on July 19, 2024

Hmm, we should probably add server side checks for that and possibly client side too.

from p-brainandroid.

patrickjquinn avatar patrickjquinn commented on July 19, 2024

Yep if the value is empty then prompt the client to enter a name value perhaps?

from p-brainandroid.

timstableford avatar timstableford commented on July 19, 2024

Theoretically it should never be empty in the first place. There's a default of 'Brain' after all. If it was set to a zero length string then something went wrong parsing the query. I suspect it picked up a "your name is" with no name. So I'm not going to go that far with client side fixes, I'll just present a warning if it's detected.

from p-brainandroid.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.