Giter VIP home page Giter VIP logo

tinify-net's People

Contributors

jshergal avatar rdennis avatar rkoopmans avatar rolftimmermans avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

tinify-net's Issues

'ToFile' is not a member of Task(Of TinifyAPI.Source)

I am implementing in VB.net

I need a version of this DLL with a strong name key, our solution gets installed in the GAC on the server and requires it.

I Forked to create a version and deployed it and I am getting the above error.

Any ideas ?

Setup an AppVeyour config and build

Setup the AppVeyour build in order to:

  • Apply the build number to package suffix (only on dev versions)
  • Build the Pull Requests, branches and master
  • Run the tests and provide feedback to github Pull Request
  • If on master, run the IntegrationTests (we don't run them on PR's because secure variables could be shown by changing the config file to output the value to the build log.
  • If on master, deploy the artifacts to Myget
  • If a tag is present, deploy the artifacts to Nuget

Create an AppVeyor account

Create an AppVeyor account in order to setup the continuous build of Pull Requests, master branches and releases to Nuget/Myget

Bump library target framework to .netstandard2.1

With the deprecation of older .Net Frameworks and older .Net Core versions, it seems like it would be good to move the library to target .Net standard2.1. This would allow access to features from newer C# versions that would allow for some performance enhancements as well as some other code cleanup. I would be happy to take on the work.

Create Myget account

Create a Myget account to place the nupkg files that are generated from the master branch.
These are expecially usefull in order to be able to test the bits not yet released.
A public feed is free.

Bump VS image version for CI build to VS2022

I believe the current build is failing due to an issue with an older version of the MSBuild tools that had an issue with the Remove tag in a project file. The current build is targeting 'Previous Visual Studio 2017'. With VS2022 out, it would probably be reasonable to bump the build to the current release.

"CompressionCount" being double charged?

I have the following code:
`public async Task<byte[]> CompressImageFromUrlAsync(string url)
{
var a1 = Tinify.CompressionCount;
var source =
await Tinify.FromUrl(url).ConfigureAwait(false); // <- CompressionCount inc here
var a2 = Tinify.CompressionCount;
var copyrighted = source.Preserve("copyright");
var a3 = Tinify.CompressionCount;
var outputBuffer = await copyrighted.ToBuffer().ConfigureAwait(false); // <- CompressionCount inc here
var a4 = Tinify.CompressionCount;

        Debug.WriteLine($"CompressImageFromUrl checkpoints: {a1}, {a2}, {a3}, {a4}");

        return outputBuffer;
    }`

It looks like my CompressionCount is being double charged. It's incremented in both the FromUrl() call and the ToBuffer() call. Unless I'm missing something.. ?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.