tink-ab / github-devstats Goto Github PK

I had to resort to https://github.com/krlvi/github-devstats/blob/master/cmd/github-devstats/main.go to figure it out.

I am interested in working with the output of the tool in jq.

The current output (as defined by https://github.com/krlvi/github-devstats/blob/master//event/pr.go#L40-L44) is 1) not proper JSON and 2) hard to automatically make it proper JSON.

The current output looks like this:

{
    ....
},
{
    ....
},
...
{
    ....
},

Notice how it ends with a semicolon. This can easily be corrected by storing the output to a file and modifying the file using your favourite text editor, however that's annoying. Two outputs that would be parsable by jq:

{
    ....
},
{
    ....
},
...
{
    ....
}

and/or

[
    {
        ....
    },
    {
        ....
    },
    ...
    {
        ....
    }
]

I vote for the former since it allows streaming the output easier.

TimeToApprove and TimeToMerge output is human friendly (since it's time.Duration):

...
{
  ...
  "time_to_merge": "2h38m9s",
  ...
  "time_to_approve": "2h36m17s",
  ...
},
...

This is very hard to parse for actual statistics, so I propose we make them time_to_merge_seconds and time_to_approve_seconds instead.

...such as Travis CI to make sure PRs don't break stuff.