tinkoff / angular-open-source-starter Goto Github PK

This is a starter project for creating open-source libraries for Angular. It is a full fledged Angular workspace with demo application and easy library addition. It is designed to be used for open-sourcing libraries on Github and has everything you'd need ready for CI, code coverage, SSR testing, StackBlitz demo deployment and more.

Home Page: https://tinkoff.github.io/angular-open-source-starter/

License: Apache License 2.0

JavaScript 17.90% TypeScript 74.32% HTML 5.89% CSS 0.83% Shell 1.05%

angular angular-library angular-library-quickstart hacktoberfest library open-source opensource starter starter-project starter-template

angular-open-source-starter's People

Contributors

Stargazers

Watchers

angular-open-source-starter's Issues

[FEATURE] Upgrade for everything

The package doesn't work out of the box with yarn and seems like it's failing on build.

Would be appreciated:

Adding jest as testing env
Storybook
Cypress or Playwright ( ability to choose would be a better choice)
Build an ability to build libraries within the libraries such as using CDK inside UI and publish it to NPM
Extend schematics so everything would be as a part of CLI instead of npm commands.

[BUG] Missing scripts `npm run build:all` | `npm run publish:all`

🐞 Bug report

Reproduction

Run this script

angular-open-source-starter/package.json

Line 34 in a6e7077

"publish": "npm run build:all && npm run publish:all"

it throws error:

➜  angular-open-source-starter git:(test) ✗ npm run publish      

> @tinkoff/[email protected] publish
> npm run build:all && npm run publish:all

npm ERR! Missing script: "build:all"

Expected behavior

No error :)

[BUG] `npm run add [your-library-name]` throws `TypeError`

🐞 Bug report

Description

See root README:

It does not work.

Reproduction

Run this npm-script:

angular-open-source-starter/package.json

Line 24 in a6e7077

"add": "schematics ./schematics/collection.json:library-starter --debug=false",

(for example, npm run add core)

it throws:

➜  npm run add core

> @tinkoff/[email protected] preadd
> npm run build:schematics


> @tinkoff/[email protected] build:schematics
> tsc -p tsconfig.schematics.json


> @tinkoff/[email protected] add
> schematics ./schematics/collection.json:library-starter --debug=false "core"

TypeError: Cannot destructure property 'dependencies' of 'packageObject' as it is null.
    at updateDemoPackage (/Users/n.barsukov/WebstormProjects/angular-open-source-starter/schematics/library-starter/index.js:30:13)
    at /Users/n.barsukov/WebstormProjects/angular-open-source-starter/schematics/library-starter/index.js:19:9
    at MergeMapSubscriber.project (/Users/n.barsukov/WebstormProjects/angular-open-source-starter/node_modules/@angular-devkit/schematics-cli/node_modules/@angular-devkit/schematics/src/rules/call.js:74:24)
    at MergeMapSubscriber._tryNext (/Users/n.barsukov/WebstormProjects/angular-open-source-starter/node_modules/@angular-devkit/schematics-cli/node_modules/rxjs/internal/operators/mergeMap.js:69:27)
    at MergeMapSubscriber._next (/Users/n.barsukov/WebstormProjects/angular-open-source-starter/node_modules/@angular-devkit/schematics-cli/node_modules/rxjs/internal/operators/mergeMap.js:59:18)
    at MergeMapSubscriber.Subscriber.next (/Users/n.barsukov/WebstormProjects/angular-open-source-starter/node_modules/@angular-devkit/schematics-cli/node_modules/rxjs/internal/Subscriber.js:66:18)
    at Observable._subscribe (/Users/n.barsukov/WebstormProjects/angular-open-source-starter/node_modules/@angular-devkit/schematics-cli/node_modules/rxjs/internal/util/subscribeToArray.js:5:20)
    at Observable._trySubscribe (/Users/n.barsukov/WebstormProjects/angular-open-source-starter/node_modules/@angular-devkit/schematics-cli/node_modules/rxjs/internal/Observable.js:44:25)
    at Observable.subscribe (/Users/n.barsukov/WebstormProjects/angular-open-source-starter/node_modules/@angular-devkit/schematics-cli/node_modules/rxjs/internal/Observable.js:30:22)
    at MergeMapOperator.call (/Users/n.barsukov/WebstormProjects/angular-open-source-starter/node_modules/@angular-devkit/schematics-cli/node_modules/rxjs/internal/operators/mergeMap.js:39:23)

Expected behavior

Versions

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Angular [e.g. 8]

Additional context

[BUG] Broken import-aliases in `demo` unit tests

🐞 Bug report

Description

Reproduction

Run nx g @nrwl/js:library meow
Open this file https://github.com/Tinkoff/angular-open-source-starter/blob/main/projects/demo/src/app/app.component.ts and add:

import {meow} from '@angular-open-source-starter/meow';

console.log(meow());

Run nx test demo

It fails with error

➜  nx test demo

> nx run demo:test 

ngcc-jest-processor: running ngcc
 FAIL  projects/demo/src/app/app.component.spec.ts
  ● Test suite failed to run

    Cannot find module '@angular-open-source-starter/meow' from 'src/app/app.component.ts'

    Require stack:
      src/app/app.component.ts
      src/app/app.browser.module.ts
      src/app/app.component.spec.ts

      1 | import {Component} from '@angular/core';
    > 2 | import {meow} from '@angular-open-source-starter/meow';
        | ^
      3 |
      4 | console.log(meow());
      5 |

      at Resolver.resolveModule (../../node_modules/jest-runtime/node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (src/app/app.component.ts:2:1)

Expected behavior

No error

[FEATURE] Make starter great again

Let's design how to update starter for new era of web :)

[BUG] npm run release does not add main package.json into commit

[FEATURE] --access public flag for allowing @scope npm publishing

🚀 Feature request

I'm using flag --access public for publish npm package with @scope .
Can find it place on schematics part i suppose

[FEATURE] add a test spec for a package by default

Now we don't generate a test spec for a new package but npm run test waits for some tests. Let's add a .spec with one simple test for each new package

[BUG] readme was not copied for npm

User has a problem with not copying of readme after publishing in NPM. We need check it out

tinkoff / angular-open-source-starter Goto Github PK

angular-open-source-starter's People

Contributors

Stargazers

Watchers

Forkers

angular-open-source-starter's Issues

🐞 Bug report

Reproduction

Expected behavior

🐞 Bug report

Description

Reproduction

Expected behavior

Versions

Additional context

🐞 Bug report

Description

Reproduction

Expected behavior

🚀 Feature request

Recommend Projects

Recommend Topics

Recommend Org