tinnou / graphql-codegen Goto Github PK

Hi! Thanks a lot for your work. It's great code generator!

In my case some class is implementing several interfaces. Their schema is like:

{
  "kind": "OBJECT",
  "name": "myClass",
  "description": "No description for myClass",
  "fields": [],
  "inputFields": null,
  "interfaces": [
    {
      "kind": "INTERFACE",
      "name": "firstInterface",
      "ofType": null
    },
    {
      "kind": "INTERFACE",
      "name": "secondInterface",
      "ofType": null
    }
  ],
  "enumValues": null,
  "possibleTypes": null
}

, so generated code should looks like:

public class MyClass implements FirstInterface, SecondInterface {
   ....
}

public interface FirstInterface {
   ....
}

public interface SecondInterface {
   ....
}

but the result of generating of the code is:

public class Appy_Deployment implements firstInterface,  implements secondInterface {
   ....
}

public interface FirstInterface {
   ....
}

public interface SecondInterface {
   ....
}

and we have:

1. duplicated "implements"
2. chain of interface names witch starts from lower letter (when interface class name starts from Upper letter).
   As a result we have compilation error.

I've already fixed this issue in my local copy, so I can push code with fixes to some branch if you grant me the appropriate permissions.

Hi!
There are some small issue with generating Enum types.

1. Class name should starts from the Upper letter.
2. We have to set some value to each line, because we haven't default constructor.
3. We should have get method for value

Now our generated code is looks like:

public enum jump {

    START, 
    END

    private String value;

    jump (String value) {
    this.value = value;
    }

    @Override
    public String toString() {
        return value;
    }
}

but. the good code would be that:

public enum **J**ump {

    START**("start")**, 
    END**("end");**

    private String value;

    jump (String value) {
    this.value = value;
    }

    **public String getValue() {
        return value;
    }**

    @Override
    public String toString() {
        return value;
    }
}

for example(or for testing), here is part of schema:

{
  "kind": "ENUM",
  "name": "game",
  "description": "Valid field values for game",
  "fields": null,
  "inputFields": null,
  "interfaces": null,
  "enumValues": [
    {
      "name": "start",
      "description": null,
      "isDeprecated": false,
      "deprecationReason": null
    },
    {
      "name": "end",
      "description": null,
      "isDeprecated": false,
      "deprecationReason": null
    }
  ],
  "possibleTypes": null
}

I've already fixed this issue, so I can push code with fixes to some branch if you provide me permissions.