Giter VIP home page Giter VIP logo

bodegamap-collab's Introduction

Bodega Map - Collaboration

Introduction

This repository is meant as a collaboration platform for the Bodega Map. The Bodega Map is a web application mapping the traditional Danish pubs / locals in the Copenhagen Area, with functionalities for registered users.

image

Changelog

See corresponding wiki page

How to collaborate

Found an issue with the website? πŸ›

Check that it is not already listed in the issues list. If not, create a new one!

Want to suggest updated metadata πŸ—ƒοΈ or submit a picture πŸ“· for some bodega?

Register as a user and you will be able to add / edit bodegas, and add pictures. Read more in the list of functionalities on this wiki page.

Have an idea? πŸ’‘

Open a discussion first in the Ideas category 😊

Want to translate in another language or a local dialect?

Currently, the website has Danish πŸ‡©πŸ‡°, English πŸ‡ΊπŸ‡Έ/πŸ‡¬πŸ‡§ and Spanish πŸ‡ͺπŸ‡¦ translations, but it is structured so that adding new languages is really easy. There are two ways you can contribute:

1. Indirect contribution by suggesting via a message, or if in doubt

Write a message with your suggestions (corrections, clarification on how to help, wish for a specific translation, etc.) in the Discussions area.

2. Direct contribution via a git pull request

If you'd like to make direct contributions to this repository and you are comfortable using git (we can also help you if you message us), please follow this procedure:

  • On Github:
  • On your machine, in a terminal:
    • Install git (see official doc)
    • Clone your fork-repository (git clone https://github.com/<your_username>/<repository_name>.git)
    • Create a new branch (git branch <branch_name>), replacing <branch_name> by whatever you like
    • Make your contribution using your favorite IDE or text editor:
      • If you want to suggest a correction to an already existing language, make that modification in the corresponding file
      • If you want to suggest a translation into a new language, copy one of the existing ones (e.g. locales/en.yaml), rename it with the corresponding ISO 639-1 language code (e.g. locale/fi.yaml) and translate all value strings. It is the values that need to be translated (right side of ":"), not the keys (left side of ":"). Refer to the english version to double-check the context.
    • Commit your changes (git commit -am "<message>" with a descriptive <message> of less than 50 characters)
    • Push your change (git push)
  • Back to Github:
    • Create a pull request to this repo: see official doc or simply click on the suggested button when you go back to your fork repository on Github)

We will look at your request as soon as possible. This is the quickest way to implement a change, and the easiest for us.

Rules

Please use English in your communication, so that we enable as many as possible to participate. All issues will be treated in English. There is however a specific discussion category for discussions in Danish 😊

bodegamap-collab's People

Contributors

tmlmt avatar vsteffan avatar

Stargazers

 avatar

Watchers

 avatar

Forkers

vsteffan

bodegamap-collab's Issues

Switching language in the Wiki area doesn't work

Describe the bug
Language stays the same

To Reproduce
Steps to reproduce the behavior:

  1. Go to Wiki page
  2. Switch locale
  3. See that the locale hasn't changed

Screenshots
N/A

Smartphone (please complete the following information):

  • Device: iPhone
  • Browser: Brave

Additional context

Load fields corresponding to columns in DataTable when opening BottomPanel

Is your feature request related to a problem? Please describe.
When we open the BottomPanel without having used any filters, most columns contain "?"

Describe the solution you'd like
Would be nice to load missing fields when opening the panel

Describe alternatives you've considered
Is this BottomPanel so useful? Could consider to decommission it

Opening times are not set to be in CET time zone

Describe the bug
When browsing the map from a different time zone, a bodega is said to be open or closed as if it were in that time zone, and not in Denmark.

Additional context
The main use case of this map is to use it while about to hit the bars, so it probably doesn't affect a lot of people. But good to solve to improve i18n

Possibility to share set of filters and a location

Is your feature request related to a problem? Please describe.
When someone says "do you know any bodegas with a billard in Valby, I'd like to share a link to the Bodega Map centered in Valby with the filter "has a billard" activated

Describe the solution you'd like
A sharing link (with icon) at the top of the filter sidebar

Describe alternatives you've considered
None

Add whether there is an outdoor terrasse

Is your feature request related to a problem? Please describe.
When the sun shines, what's not to like?

Describe the solution you'd like
Another item in "Characteristics"

Improvements to Opening Times

Is your feature request related to a problem? Please describe.
Could add some more features

Describe the solution you'd like

  • "Opens soon"
  • Use "today" in "Opens next"
  • When reopening on the same day, use "Reopens at "
  • Filter by Open on at

Direct link to specific bodega

Is your feature request related to a problem? Please describe.
Quickly sharing the info of a specific bodega on social media

Describe the solution you'd like

  • When clicking on the link, the map should open centered and zoomed on the said bodega and have the right sidepanel open with info
  • When sharing on social media, the feature image should contain the bodega's main picture as background, the name, and the logo of the Bodega Map

Indicate "closing soon"

Is your feature request related to a problem? Please describe.
Would be a good indicator to see that a close bodega is not necessarily a great option due to the place closing soon.

Describe the solution you'd like
Indicate "closing soon" in orange instead of "open" in green

Describe alternatives you've considered

  • Let it be
  • Changing the icon color

Additional context
Google Maps does something similar

Star ranking of bodegas

Is your feature request related to a problem? Please describe.
It'd be nice for users to be able to rank their bodegas

Describe the solution you'd like

  • 5 star system
  • Filter by minimum stars
  • Score to appear on social media sharing link's feature image
  • Sort by score in bottom panel
  • Statistics of top ranked ones

Describe alternatives you've considered
Does this penalize more discrete but as-respectable places, which may not get the attention they deserve

UI improvement when clicking on a bodega on mobile devices

Is your feature request related to a problem? Please describe.
Currently when clicking on a bodega, the same sidebar as on desktop is shown: it takes 3/4 of the window and it's hard to see anything else

Describe the solution you'd like
On Mobile it would be better to have

  • the sidebar coming from the bottom
  • half of the screen being left for the map
  • center the map to the bodega
  • show line 1: name, line 2: review, line 3: open or closed, smoking symbol. Then images below
  • hide close button but add a small grey bar at the top
  • listen to swipe with useSwipe on the entire sidebar
    • onSwipe: unless enlarged && swiping down && useScroll is arrived top: resize along, within min and max
    • onSwipeEnd
      • if original place:

        • if down 10%, minimize to title only
        • if up 10%, enlarge to almost all
      • if enlarged && useScroll is arrived top && swiping down

        • if down by more than 40%, minimize
        • if down by more than 10%, resize to half
        • else back to enlarged
      • if minimized:

        • if up more than 10% resize to half
        • if up more than 40% resize to enlarged

Remove Stamsteder from interface

The reference to the book "Stamsteder" stemmed from a wish by the authors to use it as a reference for their own need, but it can be a bit confusing for some visitors, not relevant for non-Copenhagen places, and unnecessary free-publicity. That reference should be removed from the interface until further notice.

Alternatives to consider for later:

  • Add more books as options
  • Add more sources in general, as options for lists (user visited lists, wish lists, books, etc.)

Show and edit closed bodegas

Unfortunately, bodegas regularly close permanently :'( but we can keep a memory of it :)

  • status = active | temporarily-closed | permanently-closed
  • show with grey marker
  • add to filter
  • edit in sidebar (admin only)

Menu layout shift when loading page

Describe the bug
During the first second when the page loads, the menu bar appears unstyled as a high column, before collapsing into how the menu is supposed to look like.

Screenshots
image

Desktop (please complete the following information):

  • OS: any
  • Browser any
  • Version: 1.25.0

Additional context
This is a bug from the Components Library. Issue to follow:
primefaces/primevue#4210

Tiles need a bit of cleaning

ERRORError: Source layer "boundary" does not exist on source "openmaptiles" as specified by style layer "admin_sub"
ERRORError: Source layer "boundary" does not exist on source "openmaptiles" as specified by style layer "admin_country_z0-4"
ERRORError: Source layer "boundary" does not exist on source "openmaptiles" as specified by style layer "admin_country_z5-"
  • update from OpenStreetMap

Add Q&A page

  • articles and structure in markdown
  • section on the left-hand side, parsed text on the right. Inspiration from vitepress
  • share on some collaboration platform

More explicit language menu

Is your feature request related to a problem? Please describe.
It may be preferable to show country flags instead of locale code (ES, EN, ...)

Cluster bodegas

Is your feature request related to a problem? Please describe.
When looking at the map, there are almost always more points than what can be displayed at the same time with the no-overlapping rule (otherwise it would get too crowded). The problem is that we may think some bodegas are not in the database, while they are in fact.

Describe the solution you'd like
A smart clustering solution. To clearly show that the point displayed is actually a cluster containing several bodegas we can uncover by clicking on them.

reCaptcha fails and can't send Contact Form

Describe the bug
As the title suggest

To Reproduce
Steps to reproduce the behavior:

  1. Go to Contact page
  2. Fill in form
  3. Tap on "Send"
  4. See error

Smartphone (please complete the following information):

  • Device: iPhone 13
  • OS: iOS 16.5.1 (c)
  • Browser: Chrome
  • BodegaMap Version: 1.22.5

Images in Bodega details (sidebar) are too smal

Describe the bug
They should be as large as the sidebar, but are not

To Reproduce
Steps to reproduce the behavior:

  1. Select a bodega
  2. Look at the image in the sidebar

Screenshots
image

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: Chrome
  • Version: 112

Smartphone (please complete the following information):

  • Device: iPhone 13
  • OS: iOS 16.5.3
  • Browser: Chrome, Safari

Bodega full details page

Is your feature request related to a problem? Please describe.
Each bodega deserves a specific page where all details are listed in a nicely formatted way

Describe the solution you'd like
Dedicated page with all details we can find in the "Details" sidebar when navigating on the map, but with some differences / additional benefits:

  • Bigger carrussel of pictures
  • Better SEO (og:image, schema.org, etc.)

Describe alternatives you've considered
Not having such a dedicated page per bodega

Additional context

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.