tobac-project / tobac-tutorials Goto Github PK

there appears to be a problem with plotting the features position in the first basic tutorial notebook

I believe the problem is caused by f = features.sel(index=itime) which should be f = features.sel(index=[itime]).

Maybe it is time to also rename master to main in this repo or was there any reason that we kept master?

Hello,
I just noticed that the time dimension in the OLR dataset used in this notebook is not consistent. The difference between subsequent datapoints varies from ~300 seconds to ~1800 seconds:

time = np.array(OLR.time)
for i in range(0, len(time)-1):
    print((time[i+1] - time[i]) / np.timedelta64(1, 's'), end = ', ')

Results in:

476.0, 301.0, 600.0, 424.0, 476.0, 300.0, 600.0, 423.0, 476.0, 301.0, 600.0, 423.0, 478.0, 298.0, 1801.0, 599.0, 425.0, 475.0, 301.0, 599.0, 425.0, 476.0, 300.0, 599.0, 424.0, 476.0, 302.0, 600.0, 422.0, 476.0, 301.0, 599.0, 425.0, 476.0, 299.0, 1801.0, 1800.0, 600.0, 425.0, 477.0, 298.0, 599.0, 424.0, 476.0, 301.0, 600.0, 424.0, 476.0, 300.0, 599.0, 425.0, 476.0, 299.0, 

The notebook seems to run OK, but I thought I'd raise this as an issue as I suspect it might have an influence on the tracking steps. Feel free to close if I've missed some part of the code that takes care of the non-constant timestep!

This issue is meant for discussions.

need to be corrected

I realized that RTD rendering have not been setup so far for the tutorial notebooks.

Next steps:

• setup rtd connection
• update .readthedoc configuration: it currently uses python3.7 and build process fails with a 'jinja2' error
• check how rendering looks like
• update readme and provide a link to RTD

I checked one notebook named Example_OLR_Tracking_satellite.ipynb and got this error:

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-21-efcc7effea23> in <module>
      1 # Feature detection and save results to file:
      2 print('starting feature detection')
----> 3 Features=tobac.themes.tobac_v1.feature_detection_multithreshold(OLR,dxy,**parameters_features)
      4 # Features=tobac.feature_detection(OLR,dxy,**parameters_features)
      5 Features.to_hdf(os.path.join(savedir,'Features.h5'),'table')

AttributeError: module 'tobac' has no attribute 'themes'

It seems this is still under developing?
This is the info of my tobac:

tobac                     1.2                        py_0    conda-forge

In the instructions on how to use the tutorials, maybe it could be useful to indicate how to install tobac with the enablement of branch switches. If you follow the instructions, you currently only install the v2.0-dev branch, since this is the branch compatible with the tutorials. I could imagine that users would like to be able to switch between v2.0-dev and main (or a different branch) when testing the tobac code for their purposes. This could be simply achieved by installing the package with:

pip install -e .

This way you have access to the code of the checked out branch, but you can easily access code from the other branches as well by when you change the branch.

I am just not sure if you need to install the conda requirements for each single branch separately or if there is a way of installing the requirements from all branches at the same time?

Doing a PR just a few minutes ago, it felt that the template could provide more structure to input more descriptive parts and not only check boxes. BTW, quite a lot check boxes ....

This error occurs in the Example_OLR_Tracking_satellite.ipynb notebook upon trying to download and extract the example data.

It is caused by the fact that while zipfile.Zipfile is called the corresponding module is never imported.
Fixing this problem is probably trivial, however I would like to know what the preferred method of extracting the temporary zipfile is as there are two possibilities:

• import zipfile
• use shutil.unpack_archive (cf. Example_OLR_Tracking_model.ipynb)

Hi, hello, when I run the first program, in the

dxy,dt=tobac.utils.get_spacings(OLR)

section, pycharm reports an error! The error content is as follows:

File "D:\DCC\DCCV02\Tobac\Tracking of deep convection.py", line 63, in <module> dxy,dt=tobac.utils.get_spacings(OLR) File "D:\Anaconda\envs\DCCV02\lib\site-packages\tobac\utils.py", line 427, in get_spacings coord_names=[coord.name() for coord in field_in.coords()] TypeError: 'DataArrayCoordinates' object is not callable
I'm a newbie and I've tried to find a way to solve this problem on the net, but can't find a way. Please help if you see it, Thanks!

Two aspects that matter

1. structure of package was changed in version 2
2. input interface does not allow to used xarray in version 1.x

Potential solutions:
for 1. make flexible relative import in all tutorial (if version == 2.x than ... else ...)
for 2. utilize wrapper function

Hi,

Are you planning to upload example notebooks for tobac version 2.xx ?