Should not hardcode the path to facebook.php about facebookserviceprovider HOT 5 CLOSED

Fixed. Not really sure what you mean about making it optional though?

from facebookserviceprovider.

What I meant was that if no path is provided by the user the facebook sdk should not be included.

from facebookserviceprovider.

But the whole point of this provider is to include the SDK. So if no path is given, then what is the purpose of loading FacebookServiceProvider in the first place?

Maybe I'm missing something though. Have you got a use case to help me get your point?

from facebookserviceprovider.

Well ok you are right, for this extension it really doesn't matter. Nevermind. :)

In general you don't want extensions to automatically include stuff. There could be conflicts between two pieces of code that try to include it. That's all.

from facebookserviceprovider.

Ah, good. Thought perhaps I was missing something.

from facebookserviceprovider.