tobiassjosten / facebookserviceprovider Goto Github PK

Would be nice if you could tag a release of this so we don't have to use dev-master :-)

It would be better to make the path a pimple parameter (since facebook does not feel like fixing their naming), and also make this optional.

PHP-SDK is on packagist now: http://packagist.org/packages/facebook/php-sdk

If you use composer to install it, you no longer need to specify the facebook.class_file option.

The Silex extensions went through a major refactoring a few weeks ago, renaming Silex\Extension to Silex\ServiceProvider. Would be nice to have this updated to the new naming "FacebookServiceProvider".

You really shouldn't be using the Facebook namespace unless you are facebook.

You can either add a submodule (PITA due to lots of nested dependencies), add instructions for fetching it into the README (simple wget command) or wait for composer to be ready, which will make this a lot easier.

I suggest you go with updating the README for now and I'd be glad to help you migrate to composer when the time comes.

The facebook PHP sdk comes with two classes. "Facebook" and "BaseFacebook".

"Facebook" extends "BaseFacebook" and adds a session_start call. This means you cannot use it in a CLI envoronment, because it will try to send headers. It would be neat to have some kind of facebook.use_session option that would use the BaseFacebook class instead.