tobozo / wifimanagertz Goto Github PK

Hello tobozo,

personally, I don't think it's a good idea that you add a favicon in your project.
I mean, the favicon is defined for the whole web server, not only the NTP part your plug-in is responsible for.

As I want to provide an own favicon, I need to see if I can "override" your /favicon.ico route again.
But I do think providing a global server favicon should not be the business of a NTP server add-on in the first place.

Thanks for considering
Andreas

I cannot find the declaration for sntp_set_sync_interval function so I get error at compiling : "sntp_set_sync_interval' was not declared in this scope"

Hello tobozo,

cool WiFiManager addition, thanks for that! :-)

Quick question how this is expected to work:
Currently, after restarting it seems to load the preferences correctly, it correctly finds out that NTP is enabled here
https://github.com/tobozo/WiFiManagerTz/blob/master/src/WiFiManagerTz.h#L36
and loads the NTP preferences accordingly.

However, it seems not to automatically apply the time configuration from the preferences at start.
This leads to the preferences correctly filled on the WiFiManager custom web page, but the time not used. I need to go to the time settings webpage after each start and click on "Submit" (without any changes in the form as all correctly prefilled). Only then the time gets actually updated.

Would it not make sense to add a configTime(); after NTP::loadPrefs(); here?
https://github.com/tobozo/WiFiManagerTz/blob/master/src/WiFiManagerTz.h#L36

This would immediately apply the saved settings and retrieve an initial time from the NTP server.

Thanks
Andreas