Drop shadow effects: how to support multiple shadows in one effect? about figma-plugin HOT 8 CLOSED

Just merged this PR #12
New version in Figma also published.

from figma-plugin.

Agreed it'd be good support multiple shadows in the same token. I know its already been linked to in the PR, but for those searching in the future here is the relevant spec issue.

It looks like Cobalt implemented support for this recently. It'd be nice if the implementation was interoperable.

from figma-plugin.

I thought to myself: why not looking at the code, to see if multiple drop shadows are supported already, and I am not missing something. Turns out that only one part of an effect is considered, by selecting effect[0], rather than considering the drop shadow effect as an array.

I am not aware of how effects are passed to the plugin, but I assumed that any drop shadow would be an entry of the effect array. That is why I forked this repo and created a PR to submit a suggestion for handling the drop shadow effects.

This is my PR: 35acf36

Please do note that a guide for contribution to this repo is still WIP. I don't know how to properly contribute to this repo. Consider my PR as a suggestion, and use it whichever way you like to. I think that treating the drop shadow effects as arrays and exporting them as such may be the best way to go.

I am curious to any feedback.

from figma-plugin.

Looks like the release (0b64358) that implemented this fix didn't get tagged in GitHub. I don't know if anyone consumes the package that way so its not a huge deal. However, this does mean the repo's homepage looks misleading since the other releases were tagged. The "Releases" section on the right still shows 2.0.0 as being the most recent release.

Other than that, it looks like this issue could be closed.

from figma-plugin.

You right, that's my bad. I'll fix it asap

from figma-plugin.

done https://github.com/tokens-bruecke/figma-plugin/releases/tag/2.1.0

from figma-plugin.

Nice! I think this issue can get closed then.

from figma-plugin.

Sorry for the delay. Indeed, this issue can be closed. Support for multiple shadows has been implemented.

from figma-plugin.