Giter VIP home page Giter VIP logo

Comments (11)

PavelLaptev avatar PavelLaptev commented on May 31, 2024 1

@dev-nicolaos updated. It's now optional

image

from figma-plugin.

PavelLaptev avatar PavelLaptev commented on May 31, 2024

Interesting. Thanks for feedback @cailborg
I'll check it out.
Which version of Style Dictionary do you use?

from figma-plugin.

cailborg avatar cailborg commented on May 31, 2024

Just latest at the moment, so 3.8.0

from figma-plugin.

PavelLaptev avatar PavelLaptev commented on May 31, 2024

Thank, and for which platform, CSS?
I'll check it in the morning 🙂

from figma-plugin.

cailborg avatar cailborg commented on May 31, 2024

Yep CSS and SCSS

from figma-plugin.

PavelLaptev avatar PavelLaptev commented on May 31, 2024

Should work fine, without value at the end. I've checked a test JSON file with Style Dictionary playground — here is a link
Looks like the reason in something else.


Also, I made Style Dictionary utils package. So, you can try to transform your tokens with it — https://github.com/tokens-bruecke/sd-utils

Here is a test repo with Github Actions — https://github.com/tokens-bruecke/tokens-deploy-with-actions

from figma-plugin.

PavelLaptev avatar PavelLaptev commented on May 31, 2024

I made a custom build. In this build, the plugin will add .value at the end of the alias string.
Can you check if it works for you?

plugin-test-2.zip

from figma-plugin.

PavelLaptev avatar PavelLaptev commented on May 31, 2024

Also, might be the reason in this:
"$value": "{base.primary.yellow.value}"
that you're using DTCG format $value

from figma-plugin.

PavelLaptev avatar PavelLaptev commented on May 31, 2024

Added value or $value (if it's the DTCG format) at the end of the alias paths.

from figma-plugin.

dev-nicolaos avatar dev-nicolaos commented on May 31, 2024

@PavelLaptev wouldn't it be more appropriate for this change to live in the style dictionary utils? The alias example provided by the spec does not append value to the end of an alias. Cobalt's (a DTCG parser) example matches the spec. Style dictionary is the only place I've seen so far where value is appended.

from figma-plugin.

PavelLaptev avatar PavelLaptev commented on May 31, 2024

@dev-nicolaos thank you for your feedback. I think you're right. I'll leave adding value at the end of an alias optional.

from figma-plugin.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.