toktok / toxic Goto Github PK

View Code? Open in Web Editor NEW

This project forked from jfreegman/toxic

27.0 27.0 4.0 17.78 MB

An ncurses-based Tox client

Home Page: https://toktok.ltd/

License: GNU General Public License v3.0

Makefile 1.82% Python 0.53% C 95.60% Objective-C 1.00% Starlark 0.11% Shell 0.93%

chat console tox

toxic's Introduction

TokTok - Toxing on Android

GSoC Project - New Tox Android Client

Up to 2016/11/10: This is a demo application showing new modern design and all the basic UI interactions. No connection, messages, audio/video calls are presented here yet.

Installation

1. Install the latest gradle-android-scala-plugin from git:

Unix:

$ git clone --depth=1 https://github.com/saturday06/gradle-android-scala-plugin
$ cd gradle-android-scala-plugin
$ ./gradlew install

Windows:

Use TortoiseGIT or any other git client to clone https://github.com/saturday06/gradle-android-scala-plugin with specifying depth = 1.
Use commandline to install the plugin:

cd /path-to-gradle-android-scala-plugin
gradlew.bat install

2. Pull the toktok project from git:

Unix:

$ git clone https://github.com/TokTok/toktok.git

To build .apk from commandline (files may appear in /toktok/build/outputs/apk):

$ cd toktok
$ ./gradlew build

Windows:

Use TortoiseGIT or any other git client to clone https://github.com/TokTok/toktok.git.

To build .apk from commandline (files may appear in /toktok/build/outputs/apk):

cd /path-to-toktok
gradlew.bat build

To run from Android Studio consider some requirements:

Android studio 2.1.2 - 2.2.2
Scala, SBT and Android Scala plugins installed
Android device with 23 API and higher (Android 6)

toxic's People

Contributors

Stargazers

Watchers

Forkers

iphydf robinlinden whoizit sandor18

toxic's Issues

Migrate to libxcb if possible

Advantages:

Proven thread-safety.
Much easier to build.
More portable.
Asynchronous API, so no need to do threading ourselves (less room for breaking thread safety).
More stuff that's less relevant to us, but still: https://xcb.freedesktop.org/Features/

I'm struggling a bit with xlib, so I'd rather ignore xlib and move to xcb.

Add an OSX build to Travis

So we can make sure toxic keeps building on OSX.

Clean up -Wunused-result warnings.

None of these are particularly bad, but this is a useful warning, so it would be good to be able to enable it and catch future ones that are bad.

deadlock on sound_notify

Running Linux 5.11.4-1-ARCH SMP aarch64 GNU/Linux on a Raspberry pi 3

Toxic version 0.10.1_r1980
Toxcore version 0.2.12

to make things more simple, I've build toxic with the following options:
make DISABLE_X11=1 DISABLE_AV=0 DISABLE_SOUND_NOTIFY=0 DISABLE_QRCODE=1 DISABLE_QRPNG=1 clean all
I don't have this issue when setting DISABLE_AV=1 DISABLE_SOUND_NOTIFY=1

edit: running headless on a raspberry, no X and without speakers (I hope so)

  Id   Target Id                                Frame
* 1    Thread 0xfffff65c5810 (LWP 8645) "toxic" 0x0000fffff7b82490 in __lll_lock_wait () from /usr/lib/libpthread.so.0
  2    Thread 0xfffff5cbbeb0 (LWP 8648) "toxic" 0x0000fffff7a9c600 in clock_nanosleep@@GLIBC_2.17 () from /usr/lib/libc.so.6
  3    Thread 0xffffed4baeb0 (LWP 8649) "toxic" 0x0000fffff7b82490 in __lll_lock_wait () from /usr/lib/libpthread.so.0
  4    Thread 0xfffff54baeb0 (LWP 8650) "toxic" 0x0000fffff7b82490 in __lll_lock_wait () from /usr/lib/libpthread.so.0
  5    Thread 0xfffff4cb9eb0 (LWP 8651) "toxic" 0x0000fffff7b82490 in __lll_lock_wait () from /usr/lib/libpthread.so.0
  6    Thread 0xffffefffeeb0 (LWP 8652) "toxic" 0x0000fffff7b82490 in __lll_lock_wait () from /usr/lib/libpthread.so.0

thread 1 (LWP 8645)

(gdb) bt
#0  0x0000fffff7b82490 in __lll_lock_wait () at /usr/lib/libpthread.so.0
#1  0x0000fffff7b7a0b8 in pthread_mutex_lock () at /usr/lib/libpthread.so.0
#2  0x0000aaaaaaad95c8 in do_toxic (m=0xaaaaaab8b420) at /home/dok/depots/toxic/src/toxic.c:1058
#3  0x0000aaaaaaadad08 in main (argc=1, argv=0xfffffffff5b8) at /home/dok/depots/toxic/src/toxic.c:1608

waiting for

#2  0x0000aaaaaaad95c8 in do_toxic (m=0xaaaaaab8b420) at /home/dok/depots/toxic/src/toxic.c:1058
1058        pthread_mutex_lock(&Winthread.lock);
(gdb) p Winthread.lock
$3 = {__data = {__lock = 2, __count = 0, __owner = 8650, __nusers = 1, __kind = 0, __spins = 0, __list = {__prev = 0x0, __next = 0x0}},
  __size = "\002\000\000\000\000\000\000\000\312!\000\000\001", '\000' <repeats 34 times>, __align = 2}

thread 3 (LWP 8649)

Waiting for the same lock as thread 1

(gdb) bt
#0  0x0000fffff7b82490 in __lll_lock_wait () at /usr/lib/libpthread.so.0
#1  0x0000fffff7b7a0b8 in pthread_mutex_lock () at /usr/lib/libpthread.so.0
#2  0x0000aaaaaaad97d0 in thread_av (data=0xaaaaaad1a670) at /home/dok/depots/toxic/src/toxic.c:1127
#3  0x0000fffff7b77f44 in start_thread () at /usr/lib/libpthread.so.0
#4  0x0000fffff7acf95c in thread_start () at /usr/lib/libc.so.6
(gdb) frame 2
#2  0x0000aaaaaaad97d0 in thread_av (data=0xaaaaaad1a670) at /home/dok/depots/toxic/src/toxic.c:1127
1127            pthread_mutex_lock(&Winthread.lock);
(gdb) p Winthread.lock
$4 = {__data = {__lock = 2, __count = 0, __owner = 8650, __nusers = 1, __kind = 0, __spins = 0, __list = {__prev = 0x0, __next = 0x0}},
  __size = "\002\000\000\000\000\000\000\000\312!\000\000\001", '\000' <repeats 34 times>, __align = 2}

thread 4 (LWP 8650)

(gdb) bt
#0  0x0000fffff7b82490 in __lll_lock_wait () at /usr/lib/libpthread.so.0
#1  0x0000fffff7b7a0b8 in pthread_mutex_lock () at /usr/lib/libpthread.so.0
#2  0x0000aaaaaaae13f0 in lock (type=output) at /home/dok/depots/toxic/src/audio_device.c:105
#3  0x0000aaaaaaae2850 in open_device
    (type=output, device_idx=0xaaaaaab07d4c <Control+68>, cb=0x0, cb_data=0x0, enable_VAD=false, sample_rate=48000, frame_duration=20, channels=1 '\001')
    at /home/dok/depots/toxic/src/audio_device.c:508
#4  0x0000aaaaaaae2b3c in open_output_device (device_idx=0xaaaaaab07d4c <Control+68>, sample_rate=48000, frame_duration=20, channels=1 '\001')
    at /home/dok/depots/toxic/src/audio_device.c:562
#5  0x0000aaaaaaace01c in m_open_device () at /home/dok/depots/toxic/src/notify.c:185
#6  0x0000aaaaaaacef00 in play_sound_internal (what=notif_error, loop=false) at /home/dok/depots/toxic/src/notify.c:513
#7  0x0000aaaaaaacf0a8 in play_notify_sound (notif=notif_error, flags=0) at /home/dok/depots/toxic/src/notify.c:546
#8  0x0000aaaaaaacf2e8 in m_play_sound (notif=notif_error, flags=0) at /home/dok/depots/toxic/src/notify.c:576
#9  0x0000aaaaaaacf3b4 in sound_notify (self=0xffffe8025f70, notif=notif_error, flags=0, id_indicator=0x0) at /home/dok/depots/toxic/src/notify.c:599
#10 0x0000aaaaaaac4e58 in input_backspace (self=0xffffe8025f70, x=0, mx_x=170) at /home/dok/depots/toxic/src/input.c:74
#11 0x0000aaaaaaac5c74 in input_handle (self=0xffffe8025f70, key=127, x=0, mx_x=170) at /home/dok/depots/toxic/src/input.c:270
#12 0x0000aaaaaaaaede4 in chat_onKey (self=0xffffe8025f70, m=0xaaaaaab8b420, key=127, ltr=false) at /home/dok/depots/toxic/src/chat.c:1093
#13 0x0000aaaaaaade468 in draw_active_window (m=0xaaaaaab8b420) at /home/dok/depots/toxic/src/windows.c:725
#14 0x0000aaaaaaad966c in thread_winref (data=0xaaaaaab8b420) at /home/dok/depots/toxic/src/toxic.c:1081
#15 0x0000fffff7b77f44 in start_thread () at /usr/lib/libpthread.so.0
#16 0x0000fffff7acf95c in thread_start () at /usr/lib/libc.so.6

waiting for lock:

#2  0x0000aaaaaaae13f0 in lock (type=output) at /home/dok/depots/toxic/src/audio_device.c:105
105         pthread_mutex_lock(&audio_state->mutex[type]);
(gdb) p audio_state->mutex[type]
$6 = {__data = {__lock = 2, __count = 0, __owner = 8652, __nusers = 1, __kind = 0, __spins = 0, __list = {__prev = 0x0, __next = 0x0}},
  __size = "\002\000\000\000\000\000\000\000\314!\000\000\001", '\000' <repeats 34 times>, __align = 2}

Accuired by thread 6 (8652)

thread 6 (LWP 8652)

(gdb) bt
#0  0x0000fffff7b82490 in __lll_lock_wait () at /usr/lib/libpthread.so.0
#1  0x0000fffff7b7a0b8 in pthread_mutex_lock () at /usr/lib/libpthread.so.0
#2  0x0000aaaaaaacdec8 in control_lock () at /home/dok/depots/toxic/src/notify.c:150
#3  0x0000aaaaaaace360 in do_playing (_p=0x0) at /home/dok/depots/toxic/src/notify.c:254
#4  0x0000fffff7b77f44 in start_thread () at /usr/lib/libpthread.so.0
#5  0x0000fffff7acf95c in thread_start () at /usr/lib/libc.so.6

Waiting on a lock accuired by thread 4:

#2  0x0000aaaaaaacdec8 in control_lock () at /home/dok/depots/toxic/src/notify.c:150
150         pthread_mutex_lock(Control.poll_mutex);
(gdb) p Control.poll_mutex
$7 = {{__data = {__lock = 2, __count = 0, __owner = 8650, __nusers = 1, __kind = 0, __spins = 0, __list = {__prev = 0x0, __next = 0x0}},
    __size = "\002\000\000\000\000\000\000\000\312!\000\000\001", '\000' <repeats 34 times>, __align = 2}}

thread 5

(gdb) t 5
[Switching to thread 5 (Thread 0xfffff4cb9eb0 (LWP 8651))]
#0  0x0000fffff7b82490 in __lll_lock_wait () from /usr/lib/libpthread.so.0
(gdb) bt
#0  0x0000fffff7b82490 in __lll_lock_wait () at /usr/lib/libpthread.so.0
#1  0x0000fffff7b7a0b8 in pthread_mutex_lock () at /usr/lib/libpthread.so.0
#2  0x0000aaaaaaad9714 in thread_cqueue (data=0xaaaaaab8b420) at /home/dok/depots/toxic/src/toxic.c:1104
#3  0x0000fffff7b77f44 in start_thread () at /usr/lib/libpthread.so.0
#4  0x0000fffff7acf95c in thread_start () at /usr/lib/libc.so.6
(gdb) frame 2
#2  0x0000aaaaaaad9714 in thread_cqueue (data=0xaaaaaab8b420) at /home/dok/depots/toxic/src/toxic.c:1104
1104            pthread_mutex_lock(&Winthread.lock);
(gdb) p Winthread.lock
$8 = {__data = {__lock = 2, __count = 0, __owner = 8650, __nusers = 1, __kind = 0, __spins = 0, __list = {__prev = 0x0, __next = 0x0}},
  __size = "\002\000\000\000\000\000\000\000\312!\000\000\001", '\000' <repeats 34 times>, __align = 2}

Build v0.13.0 crashes

Hello,

c-toxcore 0.2.18

rpmbuild -ba toxic.spec 
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.8878
+ umask 022
+ cd /home/builder/rpmbuild/BUILD
+ '[' 1 -eq 1 ']'
+ '[' 1 -eq 1 ']'
+ '[' 1 -eq 1 ']'
+ cd /home/builder/rpmbuild/BUILD
+ rm -rf toxic-0.13.0
+ /bin/gzip -dc /home/builder/rpmbuild/SOURCES/toxic-0.13.0.tar.gz
+ /usr/bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd toxic-0.13.0
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.8878
+ umask 022
+ cd /home/builder/rpmbuild/BUILD
+ cd toxic-0.13.0
+ '[' 1 -eq 1 ']'
+ '[' 1 -eq 1 ']'
+ /usr/bin/make -j8
/home/builder/rpmbuild/BUILD/toxic-0.13.0/cfg/checks/sound_notifications.mk:18: WARNING -- Toxic will be compiled without sound notifications support
/home/builder/rpmbuild/BUILD/toxic-0.13.0/cfg/checks/sound_notifications.mk:19: WARNING -- You need these libraries for sound notifications support
/home/builder/rpmbuild/BUILD/toxic-0.13.0/cfg/checks/sound_notifications.mk:20: WARNING -- freealut
  CC    autocomplete.o
  CC    avatars.o
  CC    bootstrap.o
  CC    chat.o
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/execute.h:26:0,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/autocomplete.c:35:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:164:73: error: unknown type name 'Tox_Group_Exit_Type'
 void on_group_peer_exit(Tox *m, uint32_t groupnumber, uint32_t peer_id, Tox_Group_Exit_Type exit_type,
                                                                         ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:170:59: error: unknown type name 'Tox_Group_Privacy_State'
 void on_group_privacy_state(Tox *m, uint32_t groupnumber, Tox_Group_Privacy_State privacy_state, void *userdata);
                                                           ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:171:56: error: unknown type name 'Tox_Group_Topic_Lock'
 void on_group_topic_lock(Tox *m, uint32_t groupnumber, Tox_Group_Topic_Lock topic_lock, void *userdata);
                                                        ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:177:54: error: unknown type name 'Tox_Group_Join_Fail'
 void on_group_rejected(Tox *m, uint32_t groupnumber, Tox_Group_Join_Fail type, void *userdata);
                                                      ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:179:26: error: unknown type name 'Tox_Group_Mod_Event'
                          Tox_Group_Mod_Event type, void *userdata);
                          ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:180:57: error: unknown type name 'Tox_Group_Voice_State'
 void on_group_voice_state(Tox *m, uint32_t groupnumber, Tox_Group_Voice_State voice_state, void *userdata);
                                                         ^
  CC    chat_commands.o
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/execute.h:27:0,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/autocomplete.c:35:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:200:68: error: unknown type name 'Tox_Group_Exit_Type'
     void(*onGroupPeerExit)(ToxWindow *, Tox *, uint32_t, uint32_t, Tox_Group_Exit_Type, const char *, size_t, const char *,
                                                                    ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:206:62: error: unknown type name 'Tox_Group_Privacy_State'
     void(*onGroupPrivacyState)(ToxWindow *, Tox *, uint32_t, Tox_Group_Privacy_State);
                                                              ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:207:59: error: unknown type name 'Tox_Group_Topic_Lock'
     void(*onGroupTopicLock)(ToxWindow *, Tox *, uint32_t, Tox_Group_Topic_Lock);
                                                           ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:210:58: error: unknown type name 'Tox_Group_Join_Fail'
     void(*onGroupRejected)(ToxWindow *, Tox *, uint32_t, Tox_Group_Join_Fail);
                                                          ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:211:80: error: unknown type name 'Tox_Group_Mod_Event'
     void(*onGroupModeration)(ToxWindow *, Tox *, uint32_t, uint32_t, uint32_t, Tox_Group_Mod_Event);
                                                                                ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:212:60: error: unknown type name 'Tox_Group_Voice_State'
     void(*onGroupVoiceState)(ToxWindow *, Tox *, uint32_t, Tox_Group_Voice_State);
                                                            ^
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:37:0,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/notify.h:27,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/file_transfers.h:28,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/avatars.h:26,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/avatars.c:27:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:164:73: error: unknown type name 'Tox_Group_Exit_Type'
 void on_group_peer_exit(Tox *m, uint32_t groupnumber, uint32_t peer_id, Tox_Group_Exit_Type exit_type,
                                                                         ^
make: *** [Makefile:86: /home/builder/rpmbuild/BUILD/toxic-0.13.0/build/autocomplete.o] Error 1
make: *** Waiting for unfinished jobs....
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:170:59: error: unknown type name 'Tox_Group_Privacy_State'
 void on_group_privacy_state(Tox *m, uint32_t groupnumber, Tox_Group_Privacy_State privacy_state, void *userdata);
                                                           ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:171:56: error: unknown type name 'Tox_Group_Topic_Lock'
 void on_group_topic_lock(Tox *m, uint32_t groupnumber, Tox_Group_Topic_Lock topic_lock, void *userdata);
                                                        ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:177:54: error: unknown type name 'Tox_Group_Join_Fail'
 void on_group_rejected(Tox *m, uint32_t groupnumber, Tox_Group_Join_Fail type, void *userdata);
                                                      ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:179:26: error: unknown type name 'Tox_Group_Mod_Event'
                          Tox_Group_Mod_Event type, void *userdata);
                          ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:180:57: error: unknown type name 'Tox_Group_Voice_State'
 void on_group_voice_state(Tox *m, uint32_t groupnumber, Tox_Group_Voice_State voice_state, void *userdata);
                                                         ^
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/notify.h:27:0,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/file_transfers.h:28,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/avatars.h:26,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/avatars.c:27:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:200:68: error: unknown type name 'Tox_Group_Exit_Type'
     void(*onGroupPeerExit)(ToxWindow *, Tox *, uint32_t, uint32_t, Tox_Group_Exit_Type, const char *, size_t, const char *,
                                                                    ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:206:62: error: unknown type name 'Tox_Group_Privacy_State'
     void(*onGroupPrivacyState)(ToxWindow *, Tox *, uint32_t, Tox_Group_Privacy_State);
                                                              ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:207:59: error: unknown type name 'Tox_Group_Topic_Lock'
     void(*onGroupTopicLock)(ToxWindow *, Tox *, uint32_t, Tox_Group_Topic_Lock);
                                                           ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:210:58: error: unknown type name 'Tox_Group_Join_Fail'
     void(*onGroupRejected)(ToxWindow *, Tox *, uint32_t, Tox_Group_Join_Fail);
                                                          ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:211:80: error: unknown type name 'Tox_Group_Mod_Event'
     void(*onGroupModeration)(ToxWindow *, Tox *, uint32_t, uint32_t, uint32_t, Tox_Group_Mod_Event);
                                                                                ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:212:60: error: unknown type name 'Tox_Group_Voice_State'
     void(*onGroupVoiceState)(ToxWindow *, Tox *, uint32_t, Tox_Group_Voice_State);
                                                            ^
make: *** [Makefile:86: /home/builder/rpmbuild/BUILD/toxic-0.13.0/build/avatars.o] Error 1
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:37:0,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/autocomplete.h:26,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat.c:34:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:164:73: error: unknown type name 'Tox_Group_Exit_Type'
 void on_group_peer_exit(Tox *m, uint32_t groupnumber, uint32_t peer_id, Tox_Group_Exit_Type exit_type,
                                                                         ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:170:59: error: unknown type name 'Tox_Group_Privacy_State'
 void on_group_privacy_state(Tox *m, uint32_t groupnumber, Tox_Group_Privacy_State privacy_state, void *userdata);
                                                           ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:171:56: error: unknown type name 'Tox_Group_Topic_Lock'
 void on_group_topic_lock(Tox *m, uint32_t groupnumber, Tox_Group_Topic_Lock topic_lock, void *userdata);
                                                        ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:177:54: error: unknown type name 'Tox_Group_Join_Fail'
 void on_group_rejected(Tox *m, uint32_t groupnumber, Tox_Group_Join_Fail type, void *userdata);
                                                      ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:179:26: error: unknown type name 'Tox_Group_Mod_Event'
                          Tox_Group_Mod_Event type, void *userdata);
                          ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:180:57: error: unknown type name 'Tox_Group_Voice_State'
 void on_group_voice_state(Tox *m, uint32_t groupnumber, Tox_Group_Voice_State voice_state, void *userdata);
                                                         ^
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/autocomplete.h:26:0,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat.c:34:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:200:68: error: unknown type name 'Tox_Group_Exit_Type'
     void(*onGroupPeerExit)(ToxWindow *, Tox *, uint32_t, uint32_t, Tox_Group_Exit_Type, const char *, size_t, const char *,
                                                                    ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:206:62: error: unknown type name 'Tox_Group_Privacy_State'
     void(*onGroupPrivacyState)(ToxWindow *, Tox *, uint32_t, Tox_Group_Privacy_State);
                                                              ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:207:59: error: unknown type name 'Tox_Group_Topic_Lock'
     void(*onGroupTopicLock)(ToxWindow *, Tox *, uint32_t, Tox_Group_Topic_Lock);
                                                           ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:210:58: error: unknown type name 'Tox_Group_Join_Fail'
     void(*onGroupRejected)(ToxWindow *, Tox *, uint32_t, Tox_Group_Join_Fail);
                                                          ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:211:80: error: unknown type name 'Tox_Group_Mod_Event'
     void(*onGroupModeration)(ToxWindow *, Tox *, uint32_t, uint32_t, uint32_t, Tox_Group_Mod_Event);
                                                                                ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:212:60: error: unknown type name 'Tox_Group_Voice_State'
     void(*onGroupVoiceState)(ToxWindow *, Tox *, uint32_t, Tox_Group_Voice_State);
                                                            ^
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat.h:26:0,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c:26:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:164:73: error: unknown type name 'Tox_Group_Exit_Type'
 void on_group_peer_exit(Tox *m, uint32_t groupnumber, uint32_t peer_id, Tox_Group_Exit_Type exit_type,
                                                                         ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:170:59: error: unknown type name 'Tox_Group_Privacy_State'
 void on_group_privacy_state(Tox *m, uint32_t groupnumber, Tox_Group_Privacy_State privacy_state, void *userdata);
                                                           ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:171:56: error: unknown type name 'Tox_Group_Topic_Lock'
 void on_group_topic_lock(Tox *m, uint32_t groupnumber, Tox_Group_Topic_Lock topic_lock, void *userdata);
                                                        ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:177:54: error: unknown type name 'Tox_Group_Join_Fail'
 void on_group_rejected(Tox *m, uint32_t groupnumber, Tox_Group_Join_Fail type, void *userdata);
                                                      ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:179:26: error: unknown type name 'Tox_Group_Mod_Event'
                          Tox_Group_Mod_Event type, void *userdata);
                          ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:180:57: error: unknown type name 'Tox_Group_Voice_State'
 void on_group_voice_state(Tox *m, uint32_t groupnumber, Tox_Group_Voice_State voice_state, void *userdata);
                                                         ^
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/line_info.h:26:0,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/bootstrap.c:36:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:164:73: error: unknown type name 'Tox_Group_Exit_Type'
 void on_group_peer_exit(Tox *m, uint32_t groupnumber, uint32_t peer_id, Tox_Group_Exit_Type exit_type,
                                                                         ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:170:59: error: unknown type name 'Tox_Group_Privacy_State'
 void on_group_privacy_state(Tox *m, uint32_t groupnumber, Tox_Group_Privacy_State privacy_state, void *userdata);
                                                           ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:171:56: error: unknown type name 'Tox_Group_Topic_Lock'
 void on_group_topic_lock(Tox *m, uint32_t groupnumber, Tox_Group_Topic_Lock topic_lock, void *userdata);
                                                        ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:177:54: error: unknown type name 'Tox_Group_Join_Fail'
 void on_group_rejected(Tox *m, uint32_t groupnumber, Tox_Group_Join_Fail type, void *userdata);
                                                      ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:179:26: error: unknown type name 'Tox_Group_Mod_Event'
                          Tox_Group_Mod_Event type, void *userdata);
                          ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/toxic.h:180:57: error: unknown type name 'Tox_Group_Voice_State'
 void on_group_voice_state(Tox *m, uint32_t groupnumber, Tox_Group_Voice_State voice_state, void *userdata);
                                                         ^
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat.c:45:0:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/settings.h:90:29: error: 'TOX_GROUP_MAX_PART_LENGTH' undeclared here (not in a function)
     char group_part_message[TOX_GROUP_MAX_PART_LENGTH];
                             ^
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat.h:27:0,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c:26:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:200:68: error: unknown type name 'Tox_Group_Exit_Type'
     void(*onGroupPeerExit)(ToxWindow *, Tox *, uint32_t, uint32_t, Tox_Group_Exit_Type, const char *, size_t, const char *,
                                                                    ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:206:62: error: unknown type name 'Tox_Group_Privacy_State'
     void(*onGroupPrivacyState)(ToxWindow *, Tox *, uint32_t, Tox_Group_Privacy_State);
                                                              ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:207:59: error: unknown type name 'Tox_Group_Topic_Lock'
     void(*onGroupTopicLock)(ToxWindow *, Tox *, uint32_t, Tox_Group_Topic_Lock);
                                                           ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:210:58: error: unknown type name 'Tox_Group_Join_Fail'
     void(*onGroupRejected)(ToxWindow *, Tox *, uint32_t, Tox_Group_Join_Fail);
                                                          ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:211:80: error: unknown type name 'Tox_Group_Mod_Event'
     void(*onGroupModeration)(ToxWindow *, Tox *, uint32_t, uint32_t, uint32_t, Tox_Group_Mod_Event);
                                                                                ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:212:60: error: unknown type name 'Tox_Group_Voice_State'
     void(*onGroupVoiceState)(ToxWindow *, Tox *, uint32_t, Tox_Group_Voice_State);
                                                            ^
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c:32:0:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/groupchats.h:47:33: error: 'TOX_GROUP_PEER_PUBLIC_KEY_SIZE' undeclared here (not in a function)
     uint8_t          public_key[TOX_GROUP_PEER_PUBLIC_KEY_SIZE];
                                 ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/groupchats.h:49:5: error: unknown type name 'Tox_Group_Role'
     Tox_Group_Role   role;
     ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/groupchats.h:63:27: error: 'TOX_GROUP_MAX_GROUP_NAME_LENGTH' undeclared here (not in a function)
     char       group_name[TOX_GROUP_MAX_GROUP_NAME_LENGTH + 1];
                           ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/groupchats.h:79:32: error: unknown type name 'Tox_Group_Exit_Type'
                                Tox_Group_Exit_Type exit_type,
                                ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/groupchats.h:82:56: error: unknown type name 'Tox_Group_Mod_Event'
                                  uint32_t tgt_peer_id, Tox_Group_Mod_Event type);
                                                        ^
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/line_info.h:27:0,
                 from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/bootstrap.c:36:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:200:68: error: unknown type name 'Tox_Group_Exit_Type'
     void(*onGroupPeerExit)(ToxWindow *, Tox *, uint32_t, uint32_t, Tox_Group_Exit_Type, const char *, size_t, const char *,
                                                                    ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:206:62: error: unknown type name 'Tox_Group_Privacy_State'
     void(*onGroupPrivacyState)(ToxWindow *, Tox *, uint32_t, Tox_Group_Privacy_State);
                                                              ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:207:59: error: unknown type name 'Tox_Group_Topic_Lock'
     void(*onGroupTopicLock)(ToxWindow *, Tox *, uint32_t, Tox_Group_Topic_Lock);
                                                           ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:210:58: error: unknown type name 'Tox_Group_Join_Fail'
     void(*onGroupRejected)(ToxWindow *, Tox *, uint32_t, Tox_Group_Join_Fail);
                                                          ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:211:80: error: unknown type name 'Tox_Group_Mod_Event'
     void(*onGroupModeration)(ToxWindow *, Tox *, uint32_t, uint32_t, uint32_t, Tox_Group_Mod_Event);
                                                                                ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/windows.h:212:60: error: unknown type name 'Tox_Group_Voice_State'
     void(*onGroupVoiceState)(ToxWindow *, Tox *, uint32_t, Tox_Group_Voice_State);
                                                            ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c: In function 'cmd_group_accept':
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c:241:5: error: unknown type name 'Tox_Err_Group_Invite_Accept'
     Tox_Err_Group_Invite_Accept err;
     ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c:242:28: warning: implicit declaration of function 'tox_group_invite_accept' [-Wimplicit-function-declaration]
     uint32_t groupnumber = tox_group_invite_accept(m, self->num, Friends.list[self->num].group_invite.data,
                            ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c:246:16: error: 'TOX_ERR_GROUP_INVITE_ACCEPT_OK' undeclared (first use in this function)
     if (err != TOX_ERR_GROUP_INVITE_ACCEPT_OK) {
                ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c:246:16: note: each undeclared identifier is reported only once for each function it appears in
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c:247:20: error: 'TOX_ERR_GROUP_INVITE_ACCEPT_TOO_LONG' undeclared (first use in this function)
         if (err == TOX_ERR_GROUP_INVITE_ACCEPT_TOO_LONG) {
                    ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c:258:9: warning: implicit declaration of function 'tox_group_leave' [-Wimplicit-function-declaration]
         tox_group_leave(m, groupnumber, NULL, 0, NULL);
         ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c: In function 'cmd_group_invite':
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c:277:5: error: unknown type name 'Tox_Err_Group_Invite_Friend'
     Tox_Err_Group_Invite_Friend err;
     ^
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/chat_commands.c:279:10: warning: implicit declaration of function 'tox_group_invite_friend' [-Wimplicit-function-declaration]
     if (!tox_group_invite_friend(m, groupnumber, self->num, &err)) {
          ^
In file included from /home/builder/rpmbuild/BUILD/toxic-0.13.0/src/bootstrap.c:39:0:
/home/builder/rpmbuild/BUILD/toxic-0.13.0/src/settings.h:90:29: error: 'TOX_GROUP_MAX_PART_LENGTH' undeclared here (not in a function)
     char group_part_message[TOX_GROUP_MAX_PART_LENGTH];
                             ^
make: *** [Makefile:86: /home/builder/rpmbuild/BUILD/toxic-0.13.0/build/chat_commands.o] Error 1
make: *** [Makefile:86: /home/builder/rpmbuild/BUILD/toxic-0.13.0/build/chat.o] Error 1
make: *** [Makefile:86: /home/builder/rpmbuild/BUILD/toxic-0.13.0/build/bootstrap.o] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.8878 (%build)

filter special characters from incoming FT filenames

filter '/' and '\' and '..' from incoming filename

toxic/src/chat.c

Line 622 in a86884c

 snprintf(file_path, file_path_buf_size, "%s%s", user_settings->download_path, filename); 

toxic/src/chat.c

Line 622 in a86884c

 snprintf(file_path, file_path_buf_size, "%s%s", user_settings->download_path, filename); 

Add command to toggle peer lists in groups

Makes copying things out of the terminal easier. Also avoids breaking links.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.