portfolio's People
portfolio's Issues
.vscode should not be versioned
.vscode
is listed in .gitignore
but should not be checked in version control.
Consider running git-rm with the cache option to remove this directory from version control.
Catch errors in Grammar
Do you use VSCode?
There is a Language Tools extension in the marketplace to check grammar https://marketplace.visualstudio.com/items?itemName=adamvoss.vscode-languagetool.
This should be helpful to check grammar in source files like:
Web Developer, Entreprenuer, Sport Enthusiat
https://github.com/tolu-six/portfolio/blob/master/dist/index.html#L46
Entrypoint does not exist
I observed that the entrypoint declared in package.json
doesnt exist in the repository.
Is it necessary to keep it since there is no module to require and this isn't a library? https://docs.npmjs.com/files/package.json#main
"main": "index.js",
https://github.com/tolu-six/portfolio/blob/master/package.json#L5
Font family choice
Did you know that there are myriad web fonts available to choose from beside default system fonts?
You can find fonts in the Google web fonts directory or Fontstorage. The later requires an account registration to embed fonts.
There is an online documentation in MDN for using online font services
font-family: "Segoe UI", Tahoma, Geneva, Verdana, sans-serif;
https://github.com/tolu-six/portfolio/blob/master/scss/main.scss#L14
CSS Property rules should be on different line
The CSS Property rule for opacity should go in a separate line.
width: 100%; opacity: 0.9;
https://github.com/tolu-six/portfolio/blob/master/scss/_menu.scss#L44
Social media links are missing URL locations
Social media links do not have URL locations. e.g.
<a href="#!"> <i class="fab fa-twitter fa-2x"></i> </a>
https://github.com/tolu-six/portfolio/blob/master/dist/index.html#L48
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.