Giter VIP home page Giter VIP logo

Comments (3)

tomasstolker avatar tomasstolker commented on July 30, 2024

Hi @sylacour, thanks for this first bug report :).

Do you want to use the BT-Setll or BT-NextGen models? It seems that you added BT-Settl but you are trying to read BT-NextGen? From the temperature that you chose (7000 K), you probably want to use the BT-NextGen models?

For BT-NextGen, make sure to set the teff_range to a narrow temperature range when using add_model, because this grid is gigantic...

Let me know if this solves the problem! I will do a test in the meanwhile. I am still working on having more diagnostic warnings implemented.

from species.

tomasstolker avatar tomasstolker commented on July 30, 2024

To check what the content of the database looks like, you can run:

database = species.Database()
database.list_content()

And to see which parameters are required for a particular model, e.g.:

read_model = species.ReadModel('bt-settl')
read_model.get_parameters()

Did you not get an error when adding the BT-Settl models? Because add_model probably requires the spec_res parameter?

from species.

tomasstolker avatar tomasstolker commented on July 30, 2024

After discussing offline, the problem appeared to be related to the add_model function. The use was a bit ambiguous so I have added several diagnostic warnings and errors.

Specifically, the DRIFT-PHOENIX and petitCODE models do not require the wavel_range and spec_res parameters because they are already sampled on a fixed wavelength grid. For the other models, these parameters are required such that the wavelength grid is resampled (with a linear interpolation) when storing the spectra in the database.

For example, for BT-Settl:
database.add_model(model='bt-settl', wavel_range=(0.5, 10.), spec_res=1000., teff_range=(1500., 2000.))

While for petitCODE-cool-cloudy:
database.add_model(model='petitcode-cool-cloudy', wavel_range=None, spec_res=None, teff_range=None)

Or simply:
database.add_model('petitcode-cool-cloudy')

These changes were made in commit 23947fc and available in the new release (v0.1.3)

from species.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.