Giter VIP home page Giter VIP logo

videojs-quality-selector-hls's People

Contributors

jhodges10 avatar tomexsans avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar

Forkers

jhodges10

videojs-quality-selector-hls's Issues

doesn't work due to incorrect initialization

This plugin doesn't work at all due to a change compared to the original version. The event listener is only bound after the ready event is observed, but by then the quality level events have been already sent, so this plugin misses them all.

Thank You & readme fix

I just looked into a project I am working on and wanted to finally upgrade to Video.JS 8โ€ฆ but the previous quality selector still is stuck at v7 and incompatible with v8.

So, I wanted to thank you for the effort to upgrade this package and release it on NPM.

One thing I found in the readme document. In the Vue example you have a bit of a typo (a very consistent one but allas):

qalitySelectorHls should probably be qualitySelectorHls.

In this segment:

<script setup>
import 'video.js/dist/video-js.css'
import { ref,onMounted } from 'vue';
import videojs from 'video.js';
import 'videojs-contrib-quality-levels';
import qalitySelectorHls from 'videojs-quality-selector-hls'

const videoPlayer = ref(null)

onMounted(()=>{
  // In case an error where qualitySelectorHls not found
  videojs.registerPlugin('qalitySelectorHls',qalitySelectorHls);
  const player = videojs(videoPlayer.value)
  player.qalitySelectorHls()
})
</script>

Cheers, Chris

Safari Compatibility on macOS?

Just tried this (as mentioned before).
Found this potential bug when opening a site with the video player in Safari on macOS.

Xnapper-2023-09-10-17 21 16

Basically, in a Chromium based browser it works. But in Safari it does not show?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.