tomkeuper / bwproxy2023 Goto Github PK

• Party list command
• Multiple open invites at the same time (tomkeuper/BedWars2023#216)
• Store parties in redis if redis is enabled

When a player joins Arena 1 and subsequently another player joins the same group, the second player is erroneously being allocated to a different arena instead of Arena 1. Both arenas are intended to be part of the same group, yet the assignment seems to be inconsistent.

Make sure to check before creating a Bug Report

• The issue isn't already found on the Issue tracker.
• My issue is about BWProxy2023 and not any addon.
• The issue isn't already fixed in a Release or Development Build.
• I have checked all boxes without reading them.

Type of problem

Plugin Bug

What happened?

Now the arena selector creates a list of arenas and selects the first arena from the list and this is a problem, for example when a player joins the second arena (with /bw gui solo) in the list, when other players request to join (/bw join solo). They are not sent to the second arena in the list that has a player, they are sent to the first arena in the list

Expected Behaviour

How to Reproduce

Console Log

No response

Errors

No response

Additional Info

The error I mentioned occurs after getting started, with the server console spamming 3 to 4 times. Then, suddenly or sometimes after 10-12 hours, the server goes idle, and everything starts timing out. Perhaps there's something wrong with Redis and the arenas. Additionally, I suspect another issue related to this error with an addon map selector. The map selector says "/bwmenu Solo, this group doesn't exist," but I can join the group with "/bw join Solo." This issue is occurring with two groups, while the other groups are working fine.

[12:52:56 WARN]: Exception in thread "Craft Scheduler Thread - 16" org.apache.commons.lang.UnhandledException: Plugin BWProxy2023 v${gitVer}1.0-SNAPSHOT generated an exception while executing task 28
[12:52:56 WARN]:        at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57)
[12:52:56 WARN]:        at org.github.paperspigot.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:23)
[12:52:56 WARN]:        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[12:52:56 WARN]:        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[12:52:56 WARN]:        at java.base/java.lang.Thread.run(Thread.java:840)
[12:52:56 WARN]: Caused by: java.util.ConcurrentModificationException
[12:52:56 WARN]:        at java.base/java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:970)
[12:52:56 WARN]:        at java.base/java.util.LinkedList$ListItr.next(LinkedList.java:892)
[12:52:56 WARN]:        at java.base/java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1054)
[12:52:56 WARN]:        at com.tomkeuper.bedwars.proxy.arenamanager.ArenaManager.getArena(ArenaManager.java:52)
[12:52:56 WARN]:        at com.tomkeuper.bedwars.proxy.connectionmanager.redis.RetrieveArenaTask.run(RetrieveArenaTask.java:35)
[12:52:56 WARN]:        at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftTask.run(CraftTask.java:64)
[12:52:56 WARN]:        at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:53)
[12:52:56 WARN]:        ... 4 more

Make sure to check before creating a Bug Report

• The issue isn't already found on the Issue tracker.
• My issue is about BWProxy2023 and not any addon.
• The issue isn't already fixed in a Release or Development Build.
• I have checked all boxes without reading them.

Type of problem

Plugin Bug

What happened?

The experience does not get updated instantly after a game but rather have to rejoin the lobby for it to update

Expected Behaviour

Update instantly after a game

How to Reproduce

Normal setup should do it

Console Log

No log

Errors

No error

Additional Info

No additional info

Now the arena selector creates a list of arenas and selects the first arena from the list and this is a problem, for example when a player joins the second arena (with /bw gui solo) in the list, when other players request to join (/bw join solo). They are not sent to the second arena in the list that has a player, they are sent to the first arena in the list

Make sure to check before creating a Bug Report

• The issue isn't already found on the Issue tracker.
• My issue is about BWProxy2023 and not any addon.
• The issue isn't already fixed in a Release or Development Build.
• I have checked all boxes without reading them.

Type of problem

Plugin Bug

What happened?

Experience and kills don't get updated after a game

Kill don't even update at all

Expected Behaviour

Stats to be updated correctly after a game

How to Reproduce

Just the regular setup will show

Console Log

No console log needed

Errors

No error given, just missing functionality

Additional Info

No additional info

APIs have been implemented on BedWars2023 to make it easier to create addons. It would be useful to implement the same APIs on the proxy as well to: align with bw2023 and simplify addon creation for the proxy.

Make sure to check before creating a Bug Report

• The issue isn't already found on the Issue tracker.
• My issue is about BedWars2023 and not any addon.
• The issue isn't already fixed in a Release or Development Build.
• I have checked all boxes without reading them.

Type of problem

Plugin/Server Incompatibility

What happened?

This randomply appears.

[12:37:16 WARN]: Exception in thread "Craft Scheduler Thread - 94" org.apache.commons.lang.UnhandledException: Plugin BWProxy2023 v1.0 generated an exception while executing task 47
[12:37:16 WARN]: at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftAsyncTask.run(Carbon:57)
[12:37:16 WARN]: at org.github.paperspigot.ServerSchedulerReportingWrapper.run(Carbon:23)
[12:37:16 WARN]: at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[12:37:16 WARN]: at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[12:37:16 WARN]: at java.base/java.lang.Thread.run(Thread.java:840)
[12:37:16 WARN]: Caused by: java.util.ConcurrentModificationException
[12:37:16 WARN]: at java.base/java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:970)
[12:37:16 WARN]: at java.base/java.util.LinkedList$ListItr.next(LinkedList.java:892)
[12:37:16 WARN]: at java.base/java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1054)
[12:37:16 WARN]: at com.tomkeuper.bedwars.proxy.arenamanager.ArenaManager.getArena(ArenaManager.java:41)
[12:37:16 WARN]: at com.tomkeuper.bedwars.proxy.connectionmanager.redis.RetrieveArenaTask.run(RetrieveArenaTask.java:35)
[12:37:16 WARN]: at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftTask.run(Carbon:64)
[12:37:16 WARN]: at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftAsyncTask.run(Carbon:53)
[12:37:16 WARN]: ... 4 more

Expected Behaviour

This should not appear.

How to Reproduce

server version 1.8.8 paper
velocity
bwproxy2024
connect to Redis for BUNGEE mode

check the console

Console Log

https://pastebin.com/syzzhZui

Errors

https://pastebin.com/syzzhZui

Additional Info

Here is the video of /bw join solo not working as it should (feels like plugin doesn't have the player count data? might be because of this error)

https://cdn.discordapp.com/attachments/760851293379624982/1260574221478924350/Rec_0001.mp4?ex=668fd0ba&is=668e7f3a&hm=7719058d74c1952389562e71511cf5f90885a05c6ef09bdc04518fc7490837e8&

or if it doesn't work
https://discord.com/channels/760851292826107926/760851293379624982/1260574221801619516
in bw23 discord

Is your feature request related to a problem? Please describe.
The current level-settings in config.yml is not as useful as the main plugin one as you cant customize per level.

Describe the solution you'd like
I would like the levels.yml from BedWars2023 to also be in BWProxy2023 instead of a small section in the config.yml.

Describe alternatives you've considered
Haven't thought of any other way.

Add Pages to Arena GUI

2 Image 1 from forcefully joining the Game Server with /server
second is from the BedwarProxy lobby with level and required experience not returning any value