The python-hvac from tomlxxvi

python-hvac's People

Contributors

Stargazers

Watchers

python-hvac's Issues

PumpCurve has poor fit for smaller pumps

This is a regression from pypeflow - which used a different curve fitting algorithm. PumpCurve fails to fit a good curve for the following.

pump_curve = PumpCurve.curve_fitting(
    coordinates=[
        (Q_(0.00, "m^3/h"), Q_(640.0, "cmH2O")),
        (Q_(0.60, "m^3/h"), Q_(635.0, "cmH2O")),
        (Q_(1.05, "m^3/h"), Q_(630.0, "cmH2O")),
        (Q_(1.70, "m^3/h"), Q_(500.0, "cmH2O")),
        (Q_(2.40, "m^3/h"), Q_(370.0, "cmH2O")),
        (Q_(3.60, "m^3/h"), Q_(200.0, "cmH2O")),
    ],
)

coeffs = pump_curve.coefficients
print(pump_curve.coefficients)

The underlying scipy curve fit doesn't deal well with small numbers. A quick fix for me locally was to rescale the variables before passing them to scipy:

    def curve_fitting(cls, coordinates: List[Tuple[Quantity, Quantity]], name: str = '') -> 'PumpCurve':
        V_ax = []
        dP_ax = []
        for V, dP in coordinates:
            V_ax.append(V.to('m ** 3 / hr').magnitude) # < modified on input and throughout pump_curve.py
            dP_ax.append(dP.to('Pa').magnitude)
        def objective(x, a, b, c):
            return a * x + b * x ** 2 + c

Probably the permanent solution is to detect the rough order of the inputs and rescale accordingly.

Which repo?

Hey, I noticed you have a number of repositories with duplicated content - is there any in particular you recommend using/not using?

Error using the import 'Quantity' from 'hvac'

Hi,
I cloned your repo and installed all the necessary packages via pip but the error:
cannot import name 'Quantity' from 'hvac'' continues to appear.
Is there a way to fix it.
Thanks in Advance.

Recommend Projects