Reading TypedValue Arrays from a Model about sketchup-api-c-wrapper HOT 5 OPEN

Sounds like it's accessing deleted data. I think it stems from AttributeDictionary::get_attribute

https://github.com/jimfoltz/Sketchup-API-C-Wrapper/blob/28c8523905832c84ab77802a49c6bb904a170a01/src/SUAPI-CppWrapper/model/AttributeDictionary.cpp#L137-L153

I creates a TypedValue value_out; on the stack - and then return this as a copy. But the deconstructor for value_out will release the Ref once the function exits;

https://github.com/jimfoltz/Sketchup-API-C-Wrapper/blob/28c8523905832c84ab77802a49c6bb904a170a01/src/SUAPI-CppWrapper/model/TypedValue.cpp#L156

The temporary TypedValue in AttributeDictionary::get_attribute needs to be non-owning.

This also means that the wrapper objects needs to generally be passed as refs (C++ refs) as parameters to other functions.

Side node, I think owned is a more precise term than attached;
https://github.com/jimfoltz/Sketchup-API-C-Wrapper/blob/28c8523905832c84ab77802a49c6bb904a170a01/include/SUAPI-CppWrapper/model/Entity.hpp#L59-L62

from sketchup-api-c-wrapper.

I have a feeling that this commit will fix the issue:
4c1837f

...but needs testing.

I am beginning to think that casting wrapper objects to Ref* pointers may be a bad idea. I thought it might be useful once, now I think it makes it more likely that mistakes are made with its use.

Side node, I think owned is a more precise term than attached;

I disagree - 'owned' could suggest that the wrapper object owns the Ref that it is wrapping, or that the Ref is owned by another parent Ref. Besides, general users tend not to have to deal with this variable - it is only for the developers really.

from sketchup-api-c-wrapper.

I am beginning to think that casting wrapper objects to Ref* pointers may be a bad idea. I thought it might be useful once, now I think it makes it more likely that mistakes are made with its use.

Agree - one should be careful with implicit casts.

from sketchup-api-c-wrapper.

...but needs testing.

Did you try with Jim's unit tests?

from sketchup-api-c-wrapper.

So it doesn't solve the problem, according to Jim here: 4c1837f

I'll take a look at it once I have my testing environment set up.

from sketchup-api-c-wrapper.