Not sure what this project's C++ version policy is, but since C++17 we have <code clas

[[maybe_unused]] an alternative to _unused about sketchup-api-c-wrapper HOT 4 OPEN

tommykaneko commented on September 14, 2024

[[maybe_unused]] an alternative to _unused

from sketchup-api-c-wrapper.

Comments (4)

TommyKaneko commented on September 14, 2024

Ah, this isn't for suppressing warnings. It's been a while when I did this, but (I think) it served the purpose of easily removing variables that were created for assert() checks, for production builds. I need the asserts for debugging.

from sketchup-api-c-wrapper.

thomthom commented on September 14, 2024

How is this removing any variable?

Looking at how it's used:

Sketchup-API-C-Wrapper/src/SUAPI-CppWrapper/model/TypedValue.cpp

Lines 144 to 157 in 6879346

 SUTypedValueRef TypedValue::create_typed_value() { 

 SUTypedValueRef typed_value = SU_INVALID; 

 SUResult res = SUTypedValueCreate(&typed_value); 

 assert(res == SU_ERROR_NONE); _unused(res); 

 return typed_value; 

 } 

 TypedValue::~TypedValue() { 

 if (SUIsValid(m_typed_value) && !m_attached) { 

 SUResult res = SUTypedValueRelease(&m_typed_value); 

 assert(res == SU_ERROR_NONE); _unused(res); 

 } 

 }

The results variable is created regardless. But in Release it'll be unused and produce a warning.

This should do the same, but with newer C++ semantics.

SUTypedValueRef TypedValue::create_typed_value() {
  SUTypedValueRef typed_value = SU_INVALID;
  [[maybe_unused]] auto res = SUTypedValueCreate(&typed_value);
  assert(res == SU_ERROR_NONE);
  return typed_value;
}

from sketchup-api-c-wrapper.

TommyKaneko commented on September 14, 2024

OK, thank for the tip. I will implement that. The wrapper was made initially with C++14, so I will get on and make those changes.

from sketchup-api-c-wrapper.

thomthom commented on September 14, 2024

I've been recently migrating my projects to C++20 and it's adding quite a few nice features. Even C++17 add a good chunk of useful improvements to the language.

from sketchup-api-c-wrapper.

Recommend Projects

[[maybe_unused]] an alternative to _unused about sketchup-api-c-wrapper HOT 4 OPEN

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	SUTypedValueRef TypedValue::create_typed_value() {
	SUTypedValueRef typed_value = SU_INVALID;
	SUResult res = SUTypedValueCreate(&typed_value);
	assert(res == SU_ERROR_NONE); _unused(res);
	return typed_value;
	}


	TypedValue::~TypedValue() {
	if (SUIsValid(m_typed_value) && !m_attached) {
	SUResult res = SUTypedValueRelease(&m_typed_value);
	assert(res == SU_ERROR_NONE); _unused(res);
	}
	}