topliceanu / schedule-drone Goto Github PK

check the api of rufus
check the api of https://github.com/petreboy14/redis-scheduler

I am playing with your cron module. I've noticed the scheduleAndStore saves the data in the database but it doesn't fire event. I don't know coffeescript but I think may be adding schedule(dataOrCronString, eventName, eventPayload) method on line 68 should resolve the issue.
eg.
store.save data, (err, storedEvent) =>
if err callback err
schedule '* * * * * 1', 'my-cron-event', params

Following is the javascript equivalent.

return store.save(data, function(err, storedEvent) {
if(err) return callback(err);
PersistentScheduler.super.schedule(timestamp, event, payload);
return callback(null, storedEvent);
});

ie. transform the scheduler into a service

scheduleAndStore saves the cron-job in database but it doesn't get active immediate after it's registration. Let have a scenario an user on a live project registered a cron job by hitting an api. It should be active immediate but not working as expected.

`var url = "mongodb://localhost:27017/my-test-db";
drone.setConfig(
{
persistence: {
type: 'mongodb',
connectionString: url,
eventsCollection: 'schedular',
options: {}
}
}
);

scheduler = drone.daemon();
try {
setTimeout(() => {
scheduler.scheduleAndStore('* * * * * * ', 'my-job', {
task: 'sendReport', campaignId: 'abc'
}, function () {
console.log('job registered');
});
}, 3000);
} catch (Exception) {
console.log('Exception', Exception);
}

scheduler.on('my-job', function (params) {
if (params.task == 'sendReport') {
// send campaign email
// sendEmailCampaign(params.campaignId);
}
});`

• organize the module into two distinct pieces:
  • scheduler process
  • rest api process for publishing scheduled tasks, use mortimer
• get inspiration from other projects:
  • kala
  • dalga written in Go and quite new
  • rufus
  • azure scheduler service
  • mandrill handles webhooks gracefully and [mandrill api for webhooks](
• add comments, generated docs, code coverage, examples, etc.https://mandrillapp.com/api/docs/webhooks.html)
• simplify current implementation, no need to extend event emitter
• support full configuration of webhooks, alternate urls, fallback urls, monitoring, etc.
• allow customization of endpoint requests. This should allow people to post on queues, etc. Support Amazon SQS and Azure Storage Queue. Support HTTP Basic Auth for outbount links
• [nice to have] make it api-compatible with azure scheduler
• maintain a job history, store the results for all the executed jobs
• [nice to have] add a ui for the scheduler-drone in angular.js
  • build a calendar view of the running jobs. see angular-ui:calendar
• find a way to bundle recurring jobs toghether, so they don't appear as being separated from each other
• syntax for a scheduler job, what it contains and how it translates to work docs: retry policy, http verb&url, what to do when there is an error, recurrance params, time of day, job state, outbound endpoint response, etc.
• cli interface for the daemon process
• documentation on the azure scheduler http://msdn.microsoft.com/en-us/library/azure/dn479785.aspx
• you could have a recurrent request be performed with a certain periodicity, but not after a configured date.
• human readable cron intervals
• option to specify timezone when configuring a job!

Old and busted todos

• use redis as a backend and especially it's EXPIRE NOTIFY feature
• rest api and programatic api (only when embedded in node.js applications)
• complete refactor, rewrite everything in coffeescript, use express.js for rest api, use mocha for testing