toranb / broccoli-ember-hbs-template-compiler Goto Github PK

View Code? Open in Web Editor NEW

7.0 5.0 12.0 230 KB

An opinionated filter for Broccoli that compiles handlebars templates for ember.js

License: MIT License

JavaScript 100.00%

broccoli-ember-hbs-template-compiler's Introduction

broccoli-ember-hbs-template-compiler

An opinionated filter for Broccoli that compiles handlebars templates for ember.js

Installation

npm install --save-dev broccoli-ember-hbs-template-compiler

Usage Example

module.exports = function (broccoli) {
  var templateCompiler = require('broccoli-ember-hbs-template-compiler')
  var pickFiles = require('broccoli-static-compiler')

  function preprocess (tree) {
    tree = templateCompiler(tree);
    return tree
  }

  var sourceTree = broccoli.makeTree('js');
  var templates = pickFiles(sourceTree, {
    srcDir: '/templates',
    destDir: '/templates'
  })
  var appTemplates = preprocess(templates);
  return [appTemplates];
}

What file types does it work with?

It's opinionated so you get both .hbs and .handlebars extensions out of the box

What should I look out for?

It requires the destination directory name be templates (as shown in the above example)

broccoli-ember-hbs-template-compiler's People

Contributors

Stargazers

Watchers

Forkers

ghedamat quaertym sebastianseilund mitchlloyd rwjblue shajith yonjah ebryn gabesoft stevegocoding stefanpenner iaincbeat

broccoli-ember-hbs-template-compiler's Issues

Support plain handlebars

Plain handlebars support is greatly appreciated. as discussed here.

Broken Dependency prevents install

This package cannot currently be installed because a dependency of a dependency is broken.

npm http 304 https://registry.npmjs.org/wordwrap
npm ERR! Failed to parse json
npm ERR! Unexpected end of input
npm ERR! File: /Users/runspired/.npm/wordwrap/0.0.2/package/package.json
npm ERR! Failed to parse package.json data.
npm ERR! package.json must be actual JSON, not just JavaScript.
npm ERR! 
npm ERR! This is not a bug in npm.
npm ERR! Tell the package author to fix their package.json file. JSON.parse

npm ERR! System Darwin 14.0.0
npm ERR! command "/Users/runspired/.nvm/v0.11.13/bin/node" "/Users/runspired/.nvm/v0.11.13/bin/npm" "install" "broccoli-ember-hbs-template-compiler"
npm ERR! cwd /Users/runspired/BitBucket/text2drive/ethereal
npm ERR! node -v v0.11.13
npm ERR! npm -v 1.4.9
npm ERR! file /Users/runspired/.npm/wordwrap/0.0.2/package/package.json
npm ERR! code EJSONPARSE

Supporting nested route templates

Thanks for your great Broccoli plugin!

Right now it seems that the plugin does not support templates used by nested routes. For instance, the following router would expect a post/update template.

App.Router.map(function() {
  this.resource('post', {path: '/posts/:posts_id'}, function() {
    this.route('update');
  });
});

Because / can't be used in file names, it seems impossible to compile a template and assign it to the correct key in the Ember.TEMPLATES property. Am I missing something? I'm currently replacing . in filename for /to support these template names.

handlebars 2/ember 1.9.0 support

Since the original https://github.com/toranb/ember-template-compiler already supports that in v1.9.0 alpha.
Seems like the only code changes that are necessary at index.js line 23 -

var input = compiler.precompile(string, false);

But ember-template-compiler 1.9.0 version is not available on npm, I thought of just getting it from the repo but it probably would be best to publish the version and update the dependencies.

Error pulling broccoli-ember-hbs-template-compiler 1.7.1-alpha

I published a non stable build of this project to npm by mistake yesterday. If your ember-cli apps blow up you can work around it for now by changing your version from ^1.6.1 to 1.7.0 as shown here

#10 (comment)

Sorry for the epic fail on my part - working to unpublish this at the moment

New hbs compiler for ember 1.7

@rjackson does a new compiler for 1.7 exist yet? if so I'd like to pull it in before I bump / publish the next npm release :)