totango / helm-ssm Goto Github PK

Hi,

I have something like this because I'm using sub charts

global:
db:
service_1: {{ssm /path/to/secret1 region}}

the secret is resolved, however, the --set command is not able to interpret it, since it should be
--set global.db.service_1 and not as a yaml

I noticed ansible templating just overwrite the file with the values retrieved for the duration of the job, it is a good security idea to delete the workspace after

would you consider to implement such a change?

I can open a pull request with this change if you feel it's a good idea

Hello,

When loading multiple values files containing the same key name but different contents, running helm install merges the dictionaries, but the helm-ssm plugin does not.

How to reproduce:

• file1.yml

key1:
  value1: foo
  value2: bar

• file2.yml

key1:
  value3: biz

• Install a helm chart with the ssm plugin on, loading the two values files:

helm ssm install -f file1.yml -f file2.yml [NAME] [CHART]

Expected:

The following dictionary is loaded into the helm chart:

key1:
  value1: foo
  value2: bar
  value3: biz

Actual result:

Only the dictionary contained in file2.yaml is actually loaded into the helm chart:

key1:
  value3: biz

[SSM] Options: upgrade --install --namespace=teller bitgo-express charts/bitgo-express/
[SSM] Value files: environment/crypto-eng-usva-1.yaml
[SSM] Reading environment/crypto-eng-usva-1.yaml
[SSM] Found 1 parameters
[SSM] Parameters: 
{{ssm /clusters/crypto-eng-usva-1/cryptocortex/BitGoRoleArn us-east-1}}
===============================================
sed: 1: "s:{{ssm /clusters/crypt ...": bad flag in substitute command: 'a'

I get this error every time I run it and nothing gets templated into my values file. Im running on OSX 10.14.4 and helm version 2.13.1

Since a lot of things have been changed in the recently released version 3 of Helm, it seems likely that work will be needed for the SSM plugin to support it. Please add support for Helm 3.

Also, perhaps you can join forces with https://github.com/codacy/helm-ssm while you implement an SSM plugin that is compatible Helm 3? After all, both your projects and theirs serve the same purpose.

Thanks for considering. 🙂

Hi,

I'm getting this message:
postgreSqlPassword: {{ ssm /dev/sql/password us-east-1 }}): error converting YAML to JSON: yaml: invalid map key: map[interface {}]interface {}{"ssm /dev/sql/password us-east-1":interface {}(nil)}

the file is like this

nameSpaces:
infraNameSpaceName: 'ci-cd-infra'
servicesNameSpaceName: 'ci-cd-services'

ciCdAirbnbService:
secrets:
postgreSqlPassword: {{ ssm /dev/sql/password us-east-1 }}

i ran the command aws ssm get-parameter --with-decryption --name /dev/sql/password --region us-east-1 | jq -r '.Parameter.Value'

and got the right value I don't understand what is the problem

using helm Client: &version.Version{SemVer:"v2.12.1", GitCommit:"02a47c7249b1fc6d8fd3b94e6b4babf9d818144e", GitTreeState:"clean"}

Can you please assist?

Thanks in advance