tpope / rbenv-aliases Goto Github PK

➜ ~ rbenv alias 2.0.0 --auto
2.0.0 => 2.0.0-p195
➜ ~ rbenv shell 2.0.0
➜ ~ ruby -v
ruby 2.0.0p0 (2013-02-24 revision 39474) [x86_64-darwin12.2.0]
➜ ~ rbenv which ruby
/Users/espen/.rbenv/versions/2.0.0/bin/ruby
➜ ~ ls .rbenv/versions/2.0.0
2.0.0-p195 bin include lib openssl share
➜ ~ rbenv shell 2.0.0-p195
➜ ~ ruby -v
ruby 2.0.0p195 (2013-05-14 revision 40734) [x86_64-darwin12.3.0]

$ rbenv --version
rbenv 1.0.0
$ ruby-build --version
ruby-build 20160330
$ rbenv alias 2.0 system
2.0 => system
$ rbenv versions
  system
  1.8
  1.8.7
  1.8.7-p375
  1.9
  1.9.3
  1.9.3-p551
  2.1
  2.1.9
  2.2
  2.2.4
  2.3
* 2.3.0 (set by RBENV_VERSION environment variable)
$ rbenv shell 2.0
rbenv: version `2.0' not installed

__

Why not re-alias automatically after uninstall a ruby version?

Running rbenv alias --auto should generate an alias for 2.1 which points to the latest 2.1 patchlevel/ version. Right now it only does:

1.8.7 => 1.8.7-p371
1.9.3 => 1.9.3-p429
2.0.0 => 2.0.0-p451

I think it'd be a good idea to have more aliases like this:

1.8.7 => 1.8.7-p371
1.9.3 => 1.9.3-p429
2.0.0 => 2.0.0-p451
2.1 => 2.1.5

Or alternatively:

1.8.7 => 1.8.7-p371
1.9.3 => 1.9.3-p429
2.0.0 => 2.0.0-p451
2.1.x => 2.1.5

However 2.1.x is not compatible with rvm, however 2.1 is.

@tpope I've wrapped up the PRs I had slated (mostly pulling stuff from nodenv-aliases and stuff from rbenv, but also a bug fix and feature #8)

Starting further back:

155dc44 (#11) was trivial feature, not worth a release tag, IMO
97f4203 (#14) was bug fixes, patch release if at all
9498f0d (#15) was a bug fix, patch release if at all
2673c49 (#16) was the auto re-alias after uninstall feature; probably worth a minor version bump. No BC breaks.

That's pretty much all the work that I wanted to submit, so there shouldn't be another deluge of commits from me.

Last question, do you care about a travis-ci badge on the readme? I didn't see any of your other repos with travis badges, but then again, none of them had a .travis.yml. I'll add it if you don't mind, but wanted to check. People have feelings about those readme badges.

I was in the process of doing a PR for #8 (as I've already added the feature to nodenv-aliases) when I noticed that the tests on master are failing.

git-bisect reports that cd420ba is the commit that broke the tests. I haven't dug in yet whether the test failures are true positives or false positives.

For CI, I've enabled travis on my fork and pushed a trigger build (.travis.yml was already present but it needed a commit to trigger travis.) https://travis-ci.org/jasonkarns/rbenv-aliases

Currently, cloning the repo is the only way to install this plugin. It'd be quite nice if you could also install it using Homebrew. I suspect that the pattern has been set by the ruby-build project and it's Homebrew formula.