tr7zw / waveycapes Goto Github PK
View Code? Open in Web Editor NEWThe cape shouldn't be a static slab
License: Other
The cape shouldn't be a static slab
License: Other
How to reproduce:
Forges 41.0.64+ and 41.0.94+ introduce breaking changes for waveycapes-forge-1.2.0-mc1.19.
When Wavey Capes (Forge) is installed, the cape does not disappear when elytra is equipped in the Curios slot added by Curious Elytra. It also doesn't disappear if wearing a customizable elytra from the mod of the same name (this probably also occurs on the Fabric version too).
Expected behaviour, of course, is that the cape should disappear when any elytra is equipped in any slot.
To reproduce, just equip a customizable elytra, or equip any elytra in the Curios slot.
Supposedly this is because Wavey Capes is currently hardcoded for the vanilla elytra.
Issues raised on github for the other mods:
Hidoni/CustomizableElytra#15
illusivesoulworks/elytraslot#32
System Info:
Minecraft Version: 1.16.5
Forge Version: 36.2.9
Wavey Capes Version: 1.0.4 (forge)
Customizable Elytra Version: 1.5.7 (forge)
Caelus Version: 2.1.3.1
Curios Version: 4.0.5.3
Curious Elytra Version: 4.0.2.3
Java Version: 1.8.0_242 64bit
CPU: 16x AMD Ryzen 9 5900HX with Radeon Graphics
GPU: NVIDIA GeForce RTX 3070 Laptop GPU/PCIe/SSE2
Hello
I think the size of the mod icon should be reduced or the mod icon should be replaced. In mod icon takes up about 79.17% of the binary file size.
mod version: fabric-1.4.0-mc1.20
Hello
I really like your mod I I tought that adding this same functionality for elytra would be could. Just imagine the waving wings. They also aren't static slab.
What do you think about that? If you would approve that maybe I could try to make this work and open PR?
When using the smooth cape style with a banner equipped in the trinkets cape slot with More Banner Features, both the smooth and blocky cape styles appear blocky. I can unfortunately not confirm whether this only occurs with a banner, since I do not own a cape in my account.
Hi,
With the newest build of MinecraftCapes on 1.19 and 1.18 some methods have been renamed causing a crash .
PlayerHandler.getFromPlayer
is now just PlayerHandler.get
java.lang.NoSuchMethodError: 'net.minecraftcapes.player.PlayerHandler net.minecraftcapes.player.PlayerHandler.getFromPlayer(net.minecraft.class_1657)'
at dev.tr7zw.waveycapes.support.MinecraftCapesSupport.shouldBeUsed(MinecraftCapesSupport.java:24)
at dev.tr7zw.waveycapes.renderlayers.CustomCapeRenderLayer.getCapeRenderer(CustomCapeRenderLayer.java:483)
at dev.tr7zw.waveycapes.renderlayers.CustomCapeRenderLayer.render(CustomCapeRenderLayer.java:70)
at dev.tr7zw.waveycapes.renderlayers.CustomCapeRenderLayer.method_4199(CustomCapeRenderLayer.java:41)
at net.minecraft.class_922.method_4054(class_922.java:145)
at net.minecraft.class_1007.method_4215(class_1007.java:66)
at net.minecraft.class_1007.method_3936(class_1007.java:43)
at net.minecraft.class_898.method_3954(class_898.java:141)
at net.minecraft.class_761.method_22977(class_761.java:1572)
at net.minecraft.class_761.method_22710(class_761.java:1322)
at net.minecraft.class_757.method_3188(class_757.java:1100)
at net.minecraft.class_757.method_3192(class_757.java:872)
at net.minecraft.class_310.method_1523(class_310.java:1218)
at net.minecraft.class_310.method_1514(class_310.java:801)
at net.minecraft.client.main.Main.main(Main.java:237)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:462)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Quick fix: Entity#isInvisible()
Hello I don't have a cape to display so I don't actually see what changes when changing settings on the settings screen. would be nice if the mod displayed a dummy cape (mojang cape for example) on the player when this happens so you can modify the settings and see the changes.
using wavy capes 1.1.0 and Minecraft 1.18.1
Steps to Reproduce:
Observed Results:
The cape renders in and out as you move around. Affects leather, iron, gold, diamond, and netherite chest plates
Expected results
The cape doesn't clip when sneaking around
Running on Minecraft 1.17.1, fabric 1.17.1 and Wavy Capes 1.0.3
Hi,
you have in last time with 1.3.0 and now with 1.3.1 new thinks added to Minecrafts Mod Wavey Capes. I hope you can this add in 1.12.2 Version for Minecraft. I love it but i miss so features in 1.12.2
Title says it all. Capes decoded from unascribed/Ears capable skins are not affected by Wavey Capes. Easy way out is to call it quits and mark it as incompatible, because as far as I understand from it, it uses its own feature renderer that then calls a delegate. It's a multi-version multi-loader thing of beauty.
maybe adding hover text with a short explanation of what each option does
Add a null check to /dev/tr7zw/waveycapes/VanillaCapeRenderer.java#Line 24 as it often causes crashes.
the MoreBannerFeatures compatibility fix is huge, i tried to download and use the mod in my modpack in fabric 1.20.1 (fabric loader 0.14.22) but the game is crashing when I try to enter a world, so I'm asking for this fix to be backported to Fabric 1.20.1
crash:
crash-2024-01-04_21.24.06-client.txt
the crash text says that the Firstpersonmodel mod and the Elytra Physics mod are suspicious, I tried to disable them but it gave the same problem:
crash-2024-01-04_21.26.38-client.txt
the mods both work as intended independently from each other.
From the debug.log it seems that a cape is being loaded but doesn't render in ?
This line seems to be printed to STDOUT every frame when the cape is updated, with Player Animator installed.
1.20.4
v1.4.3
What happened:
The cape occasionally clips through when an elytra is equipped in the elytra slot alongside a chestplate.
Expected:
The cape disappears or the wavey physics is applied to elytra instead.
the cape design looks cropped for some reason
maybe it has something to do with More banner features mod (lets you wear banners as capes)
https://www.curseforge.com/minecraft/mc-mods/more-banner-features
I keep my mods up-to-date by using Ferium, which is a mod manager that can check for more recent releases of mods specified on a list on CurseForge, Modrinth, and GitHub. However, for Wavey Capes it complains that 3rd party application downloads have been disabled. I expect the same issue would be encountered by various launchers that can download mods.
This also happens with Entity Culling and probably any other mods you maintain. I'll just mention it here to avoid opening a million tickets on what is essentially the same issue.
What does Height multiplier ? And what exactly does gravity ?
For gravity i kinda understood after testing but for height multiplier i really can't see
More Banner Features just added a feature to use banners as capes, with trinket integration, these two mods "work" together but WC doesn't make them sexy af
https://www.curseforge.com/minecraft/mc-mods/more-banner-features
It would be nice to have this mod in 1.21 version.
So the other day someone opened a feature request on Mekanism to add support for hiding Wavy Capes when we hide the normal cape (such as for our custom elytra). I am opening this issue though as I believe it would be better suited on Wavy Capes' end as in Mekanism we just set the cape/cloak to not render if we don't want it visible.
https://github.com/mekanism/Mekanism/blob/1.19.x/src/main/java/mekanism/client/ClientTickHandler.java#L365-L366 https://github.com/mekanism/Mekanism/blob/1.19.x/src/main/java/mekanism/client/ClientTickHandler.java#L355
The reason I think it would be better to be on Wavy Capes' end is that I believe other mods likely would disable the vanilla cape in a similar way to us and then Wavy Capes can just support all of them out of the box. I believe all that should be needed would be to add a check here for !getParentModel().cloak.visible
(it would require either an AT or a mixin to read the value of the cloak
field), but then should natively support any mods that try and hide the cape in this way.
This image shows it all:
link
I was just wondering if you still plan to support 1.19.2 or dropping in favor of 1.19.3?
I use the MinecraftCapes 1.8.9, but whenever I use the Wavey Capes mod my cape gets duplicated, Even if I deactivate the custom cape, even the optifine one gets duplicated
After testing, I found that with both JMX and WaveyCapes on,the cape cannot render properly.
This is a gif showing the problem(link broken)
i opened the mod menu config and it instantly crashed. and its not a one time thing it happens every time. idk if there's anything incompatible with it but it crashes. that's all.
I was just wondering but would a 1.7.10 be possible?
Hello!
I've noticed when some emote playing then cape with Smooth Simulation V2 with Waves wind mode settings texture goes into player body.
To be honest, I have no idea why the cape duplicates. I also submitted a log
latest.log
Hello,
I just noticed that when I use the "Smooth" cape style, the cape on my skin is much darker than it was originally.
Here's a video to demonstrate this :
Same reasons with tr7zw/NotEnoughAnimations#101
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.