tractionsoftware / gwt-traction Goto Github PK

The list of options that appear in the menu is currently built by deriving each one arithmetically, using a hard-coded interval of 30 minutes. Some client code may benefit from having this be a configurable value.

Instead of doing the equivalent checks and then calling ValueChangeEvent.fire.

This is a nice side item for issue #7 since fireIfNotEqual handles null values just fine.

At least when using the HTML4 version of the UTCDateBoxImpl -- UTCDateBoxImplHtml4 -- events are not fired for null date/time values. This case can arise when the value is empty or otherwise not a valid date value (as entered by the user).

It is possible to access the HTML4 DateBox field implementation and ask for null value events via DateBox's setFireNullValues, passing true; but this causes an error later, because the adapter event listener code in UTCDateBoxImplHtml4 does not gracefully handle the null value returned in that case by UTCDateBox.date2utc.

I don't know for sure whether the handling in UTCDateBoxImplHtml5 is better, but a quick inspection reveals that it may be: it doesn't appear to require any special handling to trigger ValueChangeEvents for null values, and if a null value were provided, it looks like it would be handled correctly.

Add support on GWT Editor to the input components

When clear() is called, DOM Exception: NOT_FOUND_ERR (8) can occur. This is because the DOM needs to be used to delete the optgroup and option tags. The normal ListBox.clear() won't work.

This doesn't really cause any problems unless "Display a notification about every script error" is checked.

Throughout the codes, timezone offsets are calculated base on new Date(0), which might be different than timezone offset for new Date().

This cause 30 minutes difference in MYT for example, which have +730 in 1970, and +800 in 2018.

https://en.wikipedia.org/wiki/Time_in_Malaysia

It should be standardized to use timezone calculated from new Date().

When the user modifies the start date/time, this controller class translates the end date/time accordingly; and likewise, if the user modifies the end date/time so that the start date/time is no longer value, it modifies the start date/time to fix that. But no events are fired when this happens because the UTCDateBox and UTCTimeBox controls' setValue methods are invoked with false as the argument for their fireEvents parameters.

And setText(String) should delegate to setText(String, boolean), passing false (to be equivalent to the current behavior).