Comments (3)
In the documentation I tried to emphasize that one GrpcContext should be created per thread as opposed to multiple contexts per thread. Running one context on multiple threads is not supported. The documentation should probably make that more explicit in the Detailed Description
section of the GrpcContext.
The idea of using one completion queue per thread comes from gRPC's Performance Best Practices which used to give that recommendation. Nowadays, it recommends one queue per two threads, but I don't want to have the additional synchronization overhead and complexity in my/user code.
To achieve multi-threading with this library you should create one thread per context as shown in this client and server example. You can then utilize one of the contexts for stranding activity.
from asio-grpc.
@Tradias thanks.
If possible, I think it might be beneficial make a version of GrpcContext that supports calling run from multiple threads. users may then choose to use asio::strand mechanism to synchronize completions.
I also think that this aspect needs better emphasis in the docs:
- it is redundant / impossible to use asio::strand
- it is prohibited to invoke run from multiple threads
from asio-grpc.
Thanks for the feedback, I am always eager to improve the documentation:
- I guess for this one I should refer to Asio's documentation which says that "Calling io_context::run() from only one thread means all event handlers execute in an implicit strand, due to the io_context's guarantee that handlers are only invoked from inside run()."
- I don't know how to make this more clear 😄
from asio-grpc.
Related Issues (20)
- [Question] : How to detect client disconnection HOT 18
- Questions about CPU usage and event multiplexing HOT 3
- GRPC_CALL_ERROR_TOO_MANY_OPERATIONS Error on Concurrent Write Operations HOT 3
- Lifetime issue in the docs HOT 2
- Example with small changes crashes HOT 6
- Why I get const correctness problems HOT 16
- Generic server example without manual buffer serializaiton? HOT 4
- Using asynchronous gRPC server and client on same context HOT 9
- Asio-gRPC seems to have TSAN warnings HOT 8
- How to detect client closed connection HOT 6
- Can I call ServerBuilder::BuildAndStart() after GrpcContext::run() HOT 2
- Questions on how to switch from an GrpcContext to io_context and back HOT 6
- How to shutdown grpc clients HOT 1
- Clarification Needed on Thread Context Switch in writer() Function (example streaming-server.cpp) HOT 8
- assertion failed: !started_ HOT 2
- Can I use asio-grpc inside an existing boost::asio application? HOT 7
- The agrpc::GrpcContext hangs forever HOT 13
- an upgrade from 2.5.1 to 2.9.1 leads to build errors HOT 6
- build fails with latest boost 1.84 HOT 4
- [Question]: Slowly receiveing client in long-lived streaming HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from asio-grpc.