Giter VIP home page Giter VIP logo

Comments (3)

Tradias avatar Tradias commented on June 8, 2024

In the documentation I tried to emphasize that one GrpcContext should be created per thread as opposed to multiple contexts per thread. Running one context on multiple threads is not supported. The documentation should probably make that more explicit in the Detailed Description section of the GrpcContext.

The idea of using one completion queue per thread comes from gRPC's Performance Best Practices which used to give that recommendation. Nowadays, it recommends one queue per two threads, but I don't want to have the additional synchronization overhead and complexity in my/user code.

To achieve multi-threading with this library you should create one thread per context as shown in this client and server example. You can then utilize one of the contexts for stranding activity.

from asio-grpc.

eladm-ultrawis avatar eladm-ultrawis commented on June 8, 2024

@Tradias thanks.

If possible, I think it might be beneficial make a version of GrpcContext that supports calling run from multiple threads. users may then choose to use asio::strand mechanism to synchronize completions.

I also think that this aspect needs better emphasis in the docs:

  • it is redundant / impossible to use asio::strand
  • it is prohibited to invoke run from multiple threads

from asio-grpc.

Tradias avatar Tradias commented on June 8, 2024

Thanks for the feedback, I am always eager to improve the documentation:

  • I guess for this one I should refer to Asio's documentation which says that "Calling io_context::run() from only one thread means all event handlers execute in an implicit strand, due to the io_context's guarantee that handlers are only invoked from inside run()."
  • I don't know how to make this more clear 😄

from asio-grpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.