traeok / keytar-rs Goto Github PK

Allowing the user to pass different configuration options will provide them with some granularity as to how they want to use keytar-rs. Suggested options include:

• "use native" or similar option to enable/disable using Node native binaries
  • When disabled, it will (eventually) fall back to @t1m0thyj 's node-password-store for native JS credential management
  • When enabled, it will operate under normal circumstances and pick the right Node binary to import from in index.js
• A "provider" option to pass a different provider instead of the default ones used for their OS
  • Currently, no providers are explicitly "defined," but structuring the current provider around this concept will make it easier to add more providers down the line.
• etc.

Currently a few tests exist to check typical user data, e.g. UTF-8, UTF-16 and mixed character sets - but it would be best to add a few more data types to ensure nothing is being lost in translation during storage/retrieval.

Suggestions:

• Test for binary data
• Test for corrupt data (?)
• Test for missing data
• Tests that explicitly break execution, to solidify core functionality

This issue might also occur with other core functions - more tests should be performed and a fix should be implemented to resolve this issue.

https://asciinema.org/a/e9ryshEZ4J1U9BhIjZYfNEB75

To connect this with PR #6 :

Error handling uses a structure and involves a lot of boilerplate to convert other error types to a "keytar" Error.

Suggestion: Use a crate such as thiserror to make an Error enum, therefore avoiding error message boilerplate and tons of impl blocks to convert error types.