Comments (13)
How are you trying to complete it? I believe, by default, the measure and draw tools "close" polygons by clicking on the first vertice in the polygon.
from outerspatial-map-library.
Double clicking, which is how it works with measure/line
from outerspatial-map-library.
Ah yes, measure does support double-click in addition to clicking on the last vertice. I'll update the title to reflect that we should make this behavior consistent.
from outerspatial-map-library.
BTW, I can't reproduce being unable to close out a polygon with the measure tool.
from outerspatial-map-library.
Same issue with measure tool, can't close out polygon on double click.
from outerspatial-map-library.
Oh, I see. I had some old code cached.
So... just to be clear: The behavior is consistent between the measure and draw tools. You can click on the first vertice to close a polygon (which is how we built it), but you want to be able to close the polygon by double-clicking (like ArcMap). Correct?
Sorry about all the back-and-forth on this. I should have verified I had the latest.
from outerspatial-map-library.
Yes, that is correct. Double click is what I intuitively tried to do, so it feels like others will do the same.
Also, a tool tip, maybe when you hover over the tools would be helpful, that way we could provide instructions. The double click would be less critical if it was clear how to close out a poly.
from outerspatial-map-library.
It's the ArcGIS in you :-) We'll get double-click added. We can do tooltips too, but that's probably going to take a little while.
from outerspatial-map-library.
Sounds good. Actually, I think it's a right click/complete poly in Arc, but yeah, it's in me and I tried that as well :)
from outerspatial-map-library.
Could you guys test to see if you can finish the polygon/line features by double clicking in both draw and measure tools across browsers?
Leaflet draw comes with this functionality out of the box but it's getting disabled in chrome on desktop. This is because leaflet >1.0.0 detects the chrome browser as touch enabled (even if you don't have a touchscreen) and in turn, leaflet turns off double click events on touch "devices"
from outerspatial-map-library.
@ryanjhodge I tested on chrome and safari. The polys close on double click in safari for both measure and draw, but not in Chrome.
If it is a hassle, not sure it's worth it to focus on this right now, might want to table this until later and move on the remaining 7.0.2 issues. Check in with @nateirwin on priorities.
If we can eventually get tool tips in there that will help.
from outerspatial-map-library.
I'll take this one on.
Not sure we want to add tooltips. Ideally the symbols used for each button are intuitive enough on their own.
from outerspatial-map-library.
Cool, I think the symbols are intuitive, but not the action needed to complete a poly.
from outerspatial-map-library.
Related Issues (20)
- Hitting the "Enter" key when the geocoderControl textfield is focused searches twice HOT 2
- On iPad, tooltips display on tap and don't go away
- Re-theme clustering icon HOT 1
- Bypass proxy and update OuterSpatial preset to support gzipping HOT 1
- Make "address" in area popup clickable
- Fix automated tests and migrate to CircleCI 2.0 config
- Map embedded in iframe within larger page causes page to scroll vertically when tapped for the first time
- Add Landscape and Satellite basemaps as presets
- Slide in popup preview from bottom when map is using docked popups and mobile device is being used
- Switching from one basemap to another then back to the first doesn't update attribution control properly
- Baselayer switcher control should pull thumbnails from Mapbox static endpoints
- Support setting an image URL in baseLayer objects for the switcher control
- Fullscreen control button should not propagate clicks
- Modify deploy-staging command to update version in package.json so default image path is setup correctly
- Basemap thumbnails link to localhost:9876 on embedded Builder Map on Mat-Su HOT 6
- Refactor OuterSpatial preset to pull campgrounds and trailheads from points_of_interest static data HOT 2
- Basemap in TRAILSMV interactive map is missing thumbnail imaage
- Switch OuterSpatial preset to production
- Filtering out campgrounds and trailheads from points_of_interest not working
- Points of interest without preset symbol do not display
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from outerspatial-map-library.