Giter VIP home page Giter VIP logo

Comments (13)

nateirwin avatar nateirwin commented on June 18, 2024

How are you trying to complete it? I believe, by default, the measure and draw tools "close" polygons by clicking on the first vertice in the polygon.

from outerspatial-map-library.

ryanbranciforte avatar ryanbranciforte commented on June 18, 2024

Double clicking, which is how it works with measure/line

from outerspatial-map-library.

nateirwin avatar nateirwin commented on June 18, 2024

Ah yes, measure does support double-click in addition to clicking on the last vertice. I'll update the title to reflect that we should make this behavior consistent.

from outerspatial-map-library.

nateirwin avatar nateirwin commented on June 18, 2024

BTW, I can't reproduce being unable to close out a polygon with the measure tool.

from outerspatial-map-library.

ryanbranciforte avatar ryanbranciforte commented on June 18, 2024

Same issue with measure tool, can't close out polygon on double click.

from outerspatial-map-library.

nateirwin avatar nateirwin commented on June 18, 2024

Oh, I see. I had some old code cached.

So... just to be clear: The behavior is consistent between the measure and draw tools. You can click on the first vertice to close a polygon (which is how we built it), but you want to be able to close the polygon by double-clicking (like ArcMap). Correct?

Sorry about all the back-and-forth on this. I should have verified I had the latest.

from outerspatial-map-library.

ryanbranciforte avatar ryanbranciforte commented on June 18, 2024

Yes, that is correct. Double click is what I intuitively tried to do, so it feels like others will do the same.

Also, a tool tip, maybe when you hover over the tools would be helpful, that way we could provide instructions. The double click would be less critical if it was clear how to close out a poly.

from outerspatial-map-library.

nateirwin avatar nateirwin commented on June 18, 2024

It's the ArcGIS in you :-) We'll get double-click added. We can do tooltips too, but that's probably going to take a little while.

from outerspatial-map-library.

ryanbranciforte avatar ryanbranciforte commented on June 18, 2024

Sounds good. Actually, I think it's a right click/complete poly in Arc, but yeah, it's in me and I tried that as well :)

from outerspatial-map-library.

ryanjhodge avatar ryanjhodge commented on June 18, 2024

Could you guys test to see if you can finish the polygon/line features by double clicking in both draw and measure tools across browsers?

Leaflet draw comes with this functionality out of the box but it's getting disabled in chrome on desktop. This is because leaflet >1.0.0 detects the chrome browser as touch enabled (even if you don't have a touchscreen) and in turn, leaflet turns off double click events on touch "devices"

from outerspatial-map-library.

ryanbranciforte avatar ryanbranciforte commented on June 18, 2024

@ryanjhodge I tested on chrome and safari. The polys close on double click in safari for both measure and draw, but not in Chrome.

If it is a hassle, not sure it's worth it to focus on this right now, might want to table this until later and move on the remaining 7.0.2 issues. Check in with @nateirwin on priorities.

If we can eventually get tool tips in there that will help.

from outerspatial-map-library.

nateirwin avatar nateirwin commented on June 18, 2024

I'll take this one on.

Not sure we want to add tooltips. Ideally the symbols used for each button are intuitive enough on their own.

from outerspatial-map-library.

ryanbranciforte avatar ryanbranciforte commented on June 18, 2024

Cool, I think the symbols are intuitive, but not the action needed to complete a poly.

from outerspatial-map-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.