Giter VIP home page Giter VIP logo

outerspatial-map-library's People

Contributors

nateirwin avatar ryanjhodge avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

outerspatial-map-library's Issues

Maki icons not showing in geojson clustered example

The layer objects in this example contains a maki element. Did this once give the clustered icons a maki icon perhaps?

maki: {
  color: '#609321',
  name: 'park'
}

Was wondering if this functionality was broken at some point and we didn't realize it or if it's supposed to be:

 styles: {
      point: {
        'marker-color': '#609321',
        'marker-symbol': 'park'
      }
    }

e.g.
https://github.com/trailheadlabs/outerspatial.js/blob/master/examples/geojson-layer-clustered.js#L11-L13
https://github.com/trailheadlabs/outerspatial.js/blob/master/examples/geojson-layer-clustered.js#L25-L28

Implement new basemap names

Now that we've "forked" Mapbox Outdoors, we should change name to "OuterSpatial Outdoors" (or something like that). We should do the same with a Satellite basemap, and potentially others as well.

Implement accessibility fixes

Contribute any appropriate fixes back into Leaflet so others can use the work.

Docs

Fixes

  • Change markup of popup title to a heading element (h1, h2, or h3?)
  • Wrap the popup close button (“x”) in a span with aria-hidden=“true” attribute and add a sibling span with descriptive text (“close popup”) that is visually hidden^
  • Add pan buttons to navigation controls (http://kartena.github.io/Leaflet.Pancontrol/)
  • Switch button images over to foreground images (from background images)
  • Focus this title header element when popup is shown, setting the tabindex to -1 before the element is focused
  • Remove title attributes from control buttons - adding the title text to alt text
  • Set tabIndex of div with npmap-map class to 0 rather than 1
  • Disable scrollWheelZoom by default and document the reason for this decision via contextual help in OuterSpatial Map Builder
  • Add more contrast to :hover and :focus states for control buttons (background-color:#333;) and also override default outlines/glows for browsers to improve the contrast
  • Use anchor elements, rather than divs, for markers and point the href attribute to the id of the popup’s div (this will require a persistent popup rather than the current approach which is destroying old and creating new popups)
  • Also place the id of the marker (or other “shape”) that opened the popup into the href attribute of the close button and give focus back to this “shape” when the popup is closed
  • Implement color palette contrast recommendations

^ Implement upstream in Leaflet

Create an OuterSpatial preset

This will allow organizations to pull in data from OuterSpatial without having to manually format popups, specify symbology, etc.

Add class to container element in fullscreen mode

Going into fullscreen mode adds inline styles for fixed positioning. That's fine, but it will be nice to also add a class to the map container element so we can style externally based on that state.

Example of fullscreen mode right now:
<div class="outerspatial" style="left: 0px; position: fixed; top: 0px;"><otherMapHTML /></div>

Something like this would work:
<div class="outerspatial fullscreen" style="left: 0px; position: fixed; top: 0px;"><otherMapHTML /></div>

Fix plugins example

Looks like the Leaflet snap plugin may be broken. Potentially because of the migration to 1.0.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.